-
Notifications
You must be signed in to change notification settings - Fork 153
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Api cleanup update #4223
Open
casibbald
wants to merge
56
commits into
main
Choose a base branch
from
api-cleanup-update
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Api cleanup update #4223
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Change field names to use snake-case
- They need to be treated as a single value
- add all docs - Adds intro and reference
- Make sure they each have a single title line - Followed by description - Remove unimplemented methods - buf lint fixes around camelCasing - Updated swagger files from EE
- Featureflags must be declared as a public route
- Adds objects tag to group all "objects" routes together
- For listing events and things
- Remove unused endpoints GetReconciledObjects and GetChildObjects
- Mark some soon to be removed endpoints as internal
Start adding documentation to fields.
- Also expand out the model in each endpoint detail block when selected.
- Move to requests.Session to simplify code
- Some more styling tweaks to remove the expansion options. Really get in the way for usability
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes
What changed?
Why was this change made?
How was this change implemented?
How did you validate the change?
Release notes
Documentation Changes