Make dialog user-agent styles apply while in top layer #41330
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpt-pr-bot
approved these changes
Aug 3, 2023
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-4739784
branch
from
0a9787e
to
cb1c0d7
Compare
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-4739784
branch
from
cb1c0d7
to
718c774
Compare
This makes it so that while the dialog element is doing an exit animation, its positioning etc. styles from the user-agent stylesheet still apply so it doesnt jump to a different spot while animating out. The :modal class is removed during this time which is why it was a problem before. We also can't just make all dialog elements always have these styles applied, because then they would also apply to non-modal dialogs. Spec: whatwg/html#9387 Fixed: 1451910 Change-Id: I4d2b240ab17879d6cf08f94f32d7c7577e9f53ea Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4739784 Commit-Queue: Joey Arhar <jarhar@chromium.org> Reviewed-by: Mason Freed <masonf@chromium.org> Cr-Commit-Position: refs/heads/main@{#1179848}
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-4739784
branch
from
718c774
to
0b12ab1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes it so that while the dialog element is doing an exit
animation, its positioning etc. styles from the user-agent stylesheet
still apply so it doesnt jump to a different spot while animating out.
The :modal class is removed during this time which is why it was a
problem before. We also can't just make all dialog elements always have
these styles applied, because then they would also apply to non-modal
dialogs.
Spec: whatwg/html#9387
Fixed: 1451910
Change-Id: I4d2b240ab17879d6cf08f94f32d7c7577e9f53ea
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4739784
Commit-Queue: Joey Arhar <jarhar@chromium.org>
Reviewed-by: Mason Freed <masonf@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1179848}