Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename dangling-markup-window-name test #41718

Merged
merged 1 commit into from
Aug 30, 2023

Conversation

chromium-wpt-export-bot
Copy link
Collaborator

@chromium-wpt-export-bot chromium-wpt-export-bot commented Aug 30, 2023

Since the dangling markup in target name is merged to the html spec[1],
let's remove the tentative name from the test.

[1] whatwg/html#9309

Bug: 1421440
Change-Id: I75a47e0c155cd81f72eafe45a9118a93b8904ba7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4827645
Auto-Submit: Jun Kokatsu <jkokatsu@google.com>
Reviewed-by: Yifan Luo <lyf@chromium.org>
Commit-Queue: Yifan Luo <lyf@chromium.org>
Commit-Queue: Jun Kokatsu <jkokatsu@google.com>
Cr-Commit-Position: refs/heads/main@{#1190256}

Copy link
Collaborator

@wpt-pr-bot wpt-pr-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The review process for this patch is being conducted in the Chromium project.

@chromium-wpt-export-bot chromium-wpt-export-bot changed the title Rename test Rename dangling-markup-window-name test Aug 30, 2023
Since the dangling markup in target name is merged to the html spec[1],
let's remove the tentative name from the test.

[1] whatwg/html#9309

Bug: 1421440
Change-Id: I75a47e0c155cd81f72eafe45a9118a93b8904ba7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4827645
Auto-Submit: Jun Kokatsu <jkokatsu@google.com>
Reviewed-by: Yifan Luo <lyf@chromium.org>
Commit-Queue: Yifan Luo <lyf@chromium.org>
Commit-Queue: Jun Kokatsu <jkokatsu@google.com>
Cr-Commit-Position: refs/heads/main@{#1190256}
@chromium-wpt-export-bot chromium-wpt-export-bot merged commit 1b0f7bb into master Aug 30, 2023
19 checks passed
@chromium-wpt-export-bot chromium-wpt-export-bot deleted the chromium-export-cl-4827645 branch August 30, 2023 20:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants