Revert "Remove empty closed paths" #44373
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-5258624
branch
from
19bee73
to
111c343
Compare
This reverts commit 572074cb06425797e7e110511db405134cf67e2f. Reason for revert: caused regression bug: crbug.com/1521614 Original change's description: > Remove empty closed paths > > As discussed in the github issue, > whatwg/html#1079, it's generally agreed to > skip drawing line caps for closed paths. This is a follow up cl of: > https://chromium-review.googlesource.com/c/chromium/src/+/4864061. > > In this cl, it verifies if each closed path is empty, then it removes > the empty closed subpaths from path. As the subpaths are removed, the > corresponding line caps are skipped. > > Bug: 644067 > > Change-Id: I14c5c4819a31eb9249d01574ff1b5c60826c3b9e > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4916516 > Commit-Queue: Yi Xu <yiyix@google.com> > Reviewed-by: Jean-Philippe Gravel <jpgravel@chromium.org> > Reviewed-by: Justin Novosad <junov@chromium.org> > Cr-Commit-Position: refs/heads/main@{#1247735} Bug: 644067 Change-Id: I33ecfd76574d6f60e6f8c471a38183f87757e3ef Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5258624 Reviewed-by: Aaron Krajeski <aaronhk@chromium.org> Reviewed-by: Jean-Philippe Gravel <jpgravel@chromium.org> Commit-Queue: Yi Xu <yiyix@google.com> Cr-Commit-Position: refs/heads/main@{#1255711}
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-5258624
branch
from
111c343
to
7f7b282
Compare
wpt-pr-bot
approved these changes
Feb 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit 572074cb06425797e7e110511db405134cf67e2f.
Reason for revert:
caused regression bug: crbug.com/1521614
Original change's description:
Bug: 644067
Change-Id: I33ecfd76574d6f60e6f8c471a38183f87757e3ef
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5258624
Reviewed-by: Aaron Krajeski <aaronhk@chromium.org>
Reviewed-by: Jean-Philippe Gravel <jpgravel@chromium.org>
Commit-Queue: Yi Xu <yiyix@google.com>
Cr-Commit-Position: refs/heads/main@{#1255711}