ARIA WG Agenda+ new namefrom: heading tests for accname #44490
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
scottaohara
reviewed
Feb 9, 2024
cookiecrook
changed the title
MelSumner
reviewed
Feb 15, 2024
There was a problem hiding this comment.
I didn't think that some of these could get their name from content. Or, are you trying to say they should be able to?
For reference, I'm looking at the list here: https://w3c.github.io/aria/#namefromcontent
scottaohara
reviewed
Feb 15, 2024
|
commenting to reference the rest of my feedback I gave on this over in another thread, as my comment contains markup patterns that might be worth adding to this wpt |
Co-authored-by: Scott O'Hara <scottaohara@users.noreply.github.com>
MelSumner
approved these changes
Mar 18, 2024
|
Test PR will need to be changed since the AccName spec PR algo will be changed from IDDFS to DFS, pending implementor approval. |
|
@MelSumner please ignore the re-requested review. I was trying to clear your approval since this PR needs more work and that big green "squash & merge" button is so tempting. I'll convert to a draft PR instead. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes web-platform-tests/interop-accessibility#47
Need feedback on this one from the ARIA WG and implementors due to the initial proposal of "iterative deepening depth first search" (IDDFS). It will likely perform better, but some authors might expect a standard (but much slower) depth first search (DFS).