Add tests of duplicate PublicKeyCredentialHint values #48096
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This relates to WebAuthn PR web-platform-tests#2145: w3c/webauthn#2145 And in turn WebAuthn issue web-platform-tests#2134: "Clarify behaviour of duplicate hints" w3c/webauthn#2135
2 tasks
nsatragno
reviewed
Sep 12, 2024
| @@ -45,7 +46,7 @@ test(() => { | |||
| ], | |||
| // The spec defaults the following fields: | |||
| attestation: "none", | |||
| hints: [], | |||
| hints: ["duplicated-value", "duplicated-value"] | |||
There was a problem hiding this comment.
This change means we no longer test the default for the hints field. If we think there's value in testing this, we should have a separate parseCreationOptionsFromJSON call with the duplicate values instead.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This relates to WebAuthn PR #2145:
And in turn WebAuthn issue #2134: "Clarify behaviour of duplicate hints"