HDKF and PBKDF2 return an empty string when length is zero #49048
+14
−14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
javifernandez
changed the title
javifernandez
force-pushed
the
hkdf-and-pbkdf2-zero-length
branch
from
980f750
to
45204d9
Compare
panva
reviewed
Nov 8, 2024
The PR#380 [1] changed the PBKDF2 deriveBits operation to allow zero length and introduced an additional step to return an empty string in that case. It also reversted the PR#275 [2] so that HKDF also handles the zero length in the same way. This PR updates the tests cases affecting this 2 algorithms on the cases where zero was passed in the length parameter. [1] w3c/webcrypto#380 [2] w3c/webcrypto#275
javifernandez
force-pushed
the
hkdf-and-pbkdf2-zero-length
branch
from
45204d9
to
194773e
Compare
panva
approved these changes
Nov 8, 2024
twiss
approved these changes
Nov 8, 2024
There was a problem hiding this comment.
LGTM 👍
However, @javifernandez do you know why the pipelines failed, or who to ask? Seems like installing Safari Technology Preview hit a 403 here: https://dev.azure.com/web-platform-tests/wpt/_build/results?buildId=129776&view=logs&j=0a19af81-f788-555d-f214-a5e35905eaf5&t=84b058e1-3bc1-5dbb-06da-ea0f1018bbe7
I'll try to get some information about it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The PR#380 [1] changed the PBKDF2 deriveBits operation to allow zero length and introduced an additional step to return an empty string in that case. It also reversted the PR#275 [2] so that HKDF also handles the zero length in the same way.
This PR updates the tests cases affecting this 2 algorithms on the cases where zero was passed in the length parameter.
[1] w3c/webcrypto#380
[2] w3c/webcrypto#275