[TASK] Avoid undefined array key access in DeeplService

This change modifies `DeeplService::translateRequest()` to mitigate undefined array key access errors.
web-vision · Apr 15, 2024 · 982311d · 982311d
1 parent 202765e
commit 982311d
Showing 1 changed file with 5 additions and 2 deletions.
diff --git a/Classes/Service/DeeplService.php b/Classes/Service/DeeplService.php
@@ -53,20 +53,23 @@ public function translateRequest(
         string $targetLanguage,
         string $sourceLanguage
     ) {
+        $glossaryId = '';
         // If the source language is set to Autodetect, no glossary can be detected.
         if ($sourceLanguage === 'auto') {
             $sourceLanguage = null;
-            $glossary['glossary_id'] = '';
         } else {
             // @todo Make glossary findable by current site.
             $glossary = $this->glossaryRepository->getGlossaryBySourceAndTarget(
                 $sourceLanguage,
                 $targetLanguage,
                 DeeplBackendUtility::detectCurrentPage()
             );
+            if ($glossary['glossary_id'] !== '') {
+                $glossaryId = $glossary['glossary_id'];
+            }
         }
 
-        $response = $this->client->translate($content, $sourceLanguage, $targetLanguage, $glossary['glossary_id']);
+        $response = $this->client->translate($content, $sourceLanguage, $targetLanguage, $glossaryId);
 
         if ($response === null) {
             if (!Environment::isCli() || !Environment::getContext()->isTesting()) {