Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Export hair springBones. #357

Open
wants to merge 15 commits into
base: stable
Choose a base branch
from
Open

Export hair springBones. #357

wants to merge 15 commits into from

Conversation

gonnavis
Copy link
Contributor

@gonnavis gonnavis commented Mar 4, 2023

Sibling PR: webaverse-studios/character-assets#2

Support exporting vrm with hair springBones.

  • Support all 10 hair types of drophunter buns, curledbangs, dreds, longspike, ponytail, short, shortband, shortcurve, straight, swept.
  • Support 6 hair types of neurohacker hair1, hair2, hair4, braided, straight, straightdown. Other 4 hair types hair3, hair5, short, hairshort too short, should not need springBones.
b5098090e8b3bcf941d303b04b4b5c5b.mp4

@vercel
Copy link

vercel bot commented Mar 4, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated
character-creator ✅ Ready (Inspect) Visit Preview 💬 Add your feedback Mar 18, 2023 at 11:38AM (UTC)

@memelotsqui memelotsqui linked an issue Mar 7, 2023 that may be closed by this pull request
@gonnavis gonnavis self-assigned this Mar 13, 2023
@gonnavis gonnavis changed the title Export springBone. Export hair springBones. Mar 18, 2023
@gonnavis gonnavis marked this pull request as ready for review March 18, 2023 11:46
Copy link
Contributor

@memelotsqui memelotsqui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ive been looking though it and I think its great for now :) .
This will only work for hair spring bones with naming conventions, but I think we can make it work in future for every spring bone defined in the vrm spec, but for this pr, I think its a good start towards fully supporting all spring bones in future

@gonnavis
Copy link
Contributor Author

This will only work for hair spring bones with naming conventions, but I think we can make it work in future for every spring bone defined in the vrm spec, but for this pr, I think its a good start towards fully supporting all spring bones in future

Yea, it currently based on naming conventions.
Do you mean to read the springBones defined in trait vrms? That's doable, I'll try in later PR!

@memelotsqui
Copy link
Contributor

Awesome 💯!, Will just wait in case there is any additional review from cosmo :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Review
Development

Successfully merging this pull request may close these issues.

Add springbones support in downloaded VRM
2 participants