feat(tests): Run tests for both Chrome and Firefox #162
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`-binary` should point at e.g. firefox.exe, not geckodriver.exe
|
@christian-bromann fixed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
npm testwill now test both chrome and firefox browsers.Refs #152
Adding support for testing against Safari will require a different approach. My first thought is passing an environment variable and conditionally generating a
wdio.conf.jsthat excludes the chrome & firefox capabilities. The GitHub Action job for testing would then be updated with a macOS host test that specifies this environment variable. (I don't plan to implement this myself, btw.)