Skip to content

Commit

Permalink
Merge pull request #1548 from musicEnfanthen/feature/corrections
Browse files Browse the repository at this point in the history
feat(edition): add corrections to source descriptions
  • Loading branch information
musicEnfanthen authored Jun 4, 2024
2 parents 31418d5 + f4041a9 commit aa70b38
Show file tree
Hide file tree
Showing 19 changed files with 909 additions and 54 deletions.
10 changes: 5 additions & 5 deletions src/app/side-info/edition-info/edition-info.component.html
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ <h5 id="awg-edition-info-header">{{ editionInfoHeader }}</h5>
class="awg-edition-info-header-link"
[routerLink]="[
editionRouteConstants.EDITION.route,
editionRouteConstants.SERIES.route
editionRouteConstants.SERIES.route,
]"
>{{ editionRouteConstants.SERIES.full }}</a
>
Expand All @@ -26,7 +26,7 @@ <h5 id="awg-edition-info-header">{{ editionInfoHeader }}</h5>
class="awg-edition-info-header-link"
[routerLink]="[
editionRouteConstants.EDITION.route,
editionRouteConstants.ROWTABLES.route
editionRouteConstants.ROWTABLES.route,
]"
>{{ editionRouteConstants.ROWTABLES.full }}</a
>
Expand Down Expand Up @@ -59,7 +59,7 @@ <h5 id="awg-edition-info-header">{{ editionInfoHeader }}</h5>
class="awg-edition-info-header-link"
[routerLink]="[
editionComplex.baseRoute,
editionRouteConstants.EDITION_SHEETS.route
editionRouteConstants.EDITION_SHEETS.route,
]"
>{{ editionTypeConstants.SKETCH_EDITION.full }}</a
>
Expand All @@ -69,7 +69,7 @@ <h5 id="awg-edition-info-header">{{ editionInfoHeader }}</h5>
class="awg-edition-info-header-link"
[routerLink]="[
editionComplex.baseRoute,
editionRouteConstants.EDITION_GRAPH.route
editionRouteConstants.EDITION_GRAPH.route,
]"
>{{ editionRouteConstants.EDITION_GRAPH.short }}</a
>
Expand Down Expand Up @@ -109,7 +109,7 @@ <h5 id="awg-edition-info-header">{{ editionInfoHeader }}</h5>
class="awg-edition-info-header-link"
[routerLink]="[
editionComplex.baseRoute,
editionRouteConstants.EDITION_SHEETS.route
editionRouteConstants.EDITION_SHEETS.route,
]"
>{{ editionTypeConstants.SKETCH_EDITION.full }}</a
>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -102,7 +102,7 @@
[ngClass]="{
btn: true,
'btn-outline-success': resourceInfoFormGroup.valid,
'btn-outline-danger': resourceInfoFormGroup.invalid
'btn-outline-danger': resourceInfoFormGroup.invalid,
}"
id="awg-resource-info-input-group-text"
[disabled]="
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@
id="awg-fulltext-search-searchValue"
class="form-control"
[ngClass]="{
'is-invalid': isFulltextSearchInputInvalid()
'is-invalid': isFulltextSearchInputInvalid(),
}"
formControlName="searchvalControl"
[attr.aria-label]="fulltextSearchFormStrings.label"
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -3,8 +3,8 @@ import { NgModule } from '@angular/core';
import { SharedModule } from '@awg-shared/shared.module';

import { EditionTkaModule } from '../edition-tka/edition-tka.module';
import { SourceDescriptionModule } from './source-description/source-description.module';

import { SourceDescriptionComponent } from './source-description';
import { SourceEvaluationComponent } from './source-evaluation';
import { SourceListComponent } from './source-list';
import { TextcriticsListComponent } from './textcritics-list';
Expand All @@ -21,10 +21,9 @@ import { EditionReportRoutingModule, routedEditionReportComponents } from './edi
* {@link SourceDescriptionComponent}, and {@link SourceEvaluationComponent}.
*/
@NgModule({
imports: [SharedModule, EditionTkaModule, EditionReportRoutingModule],
imports: [SharedModule, EditionTkaModule, SourceDescriptionModule, EditionReportRoutingModule],
declarations: [
TextcriticsListComponent,
SourceDescriptionComponent,
SourceEvaluationComponent,
SourceListComponent,
routedEditionReportComponents,
Expand Down
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
export * from './source-description-corrections.component';
Original file line number Diff line number Diff line change
@@ -0,0 +1,25 @@
<div class="awg-source-description-corrections">
<p class="no-para"><span class="smallcaps">Korrekturen:</span></p>
@for (correction of corrections; track correction.id) {
<details class="half-para awg-source-description-correction-details" [id]="correction.id">
<summary
class="half-para awg-source-description-correction-summary"
[compile-html]="correction.label + ':'"
[compile-html-ref]="ref"></summary>
@for (description of correction.description; track description) {
<p
class="awg-source-description-correction-desc"
[compile-html]="description"
[compile-html-ref]="ref"></p>
}
<awg-edition-tka-table
[textcriticalComments]="correction.comments"
[isCorrections]="true"
[isRowTable]="correction.rowtable"
(navigateToReportFragmentRequest)="navigateToReportFragment($event)"
(openModalRequest)="openModal($event)"
(selectSvgSheetRequest)="selectSvgSheet($event)">
</awg-edition-tka-table>
</details>
}
</div>
Loading

0 comments on commit aa70b38

Please sign in to comment.