Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(edition): remove placeholder for now available sources #1529

Conversation

musicEnfanthen
Copy link
Member

This PR removes placeholder from textcritics and source lists in op12 and op25. The targeted sources are now available.

@musicEnfanthen musicEnfanthen requested a review from masthom May 29, 2024 17:49
@musicEnfanthen
Copy link
Member Author

musicEnfanthen commented May 29, 2024

ref.openModal('OP12_SOURCE_NOT_AVAILABLE') --> ref.navigateToReportFragment('source_XYZ')

Copy link

codecov bot commented May 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 77.56%. Comparing base (e4d8aba) to head (67ca2b3).

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff            @@
##           develop    #1529   +/-   ##
========================================
  Coverage    77.56%   77.56%           
========================================
  Files          245      245           
  Lines         4008     4008           
  Branches       615      615           
========================================
  Hits          3109     3109           
  Misses         880      880           
  Partials        19       19           
Flag Coverage Δ
unittests 77.56% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e4d8aba...67ca2b3. Read the comment docs.

Copy link
Contributor

@masthom masthom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@musicEnfanthen musicEnfanthen merged commit 4296d63 into webern-unibas-ch:develop May 30, 2024
15 checks passed
@musicEnfanthen musicEnfanthen deleted the feature/remove-placeholder branch May 30, 2024 12:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants