Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(edition): add corrections to source descriptions #1548

Merged

Conversation

musicEnfanthen
Copy link
Member

This PR adds the possibility to include correction lists in the source description of a source.

@musicEnfanthen
Copy link
Member Author

Sample output:

Screenshot 2024-06-03 202407

@musicEnfanthen
Copy link
Member Author

@masthom

Maybe you can check

src/assets/data/edition/series/1/section/5/op12/source-description.json

if it is correct like this?

Copy link

codecov bot commented Jun 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 77.67%. Comparing base (31418d5) to head (dfa2ad3).

Current head dfa2ad3 differs from pull request most recent head f4041a9

Please upload reports for the commit f4041a9 to get more accurate results.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #1548      +/-   ##
===========================================
+ Coverage    77.59%   77.67%   +0.07%     
===========================================
  Files          246      247       +1     
  Lines         4013     4027      +14     
  Branches       616      619       +3     
===========================================
+ Hits          3114     3128      +14     
  Misses         880      880              
  Partials        19       19              
Flag Coverage Δ
unittests 77.67% <100.00%> (+0.07%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...ctions/source-description-corrections.component.ts 100.00% <100.00%> (ø)
...source-description/source-description.component.ts 100.00% <100.00%> (ø)
src/testing/mock-data/mockEditionData.ts 100.00% <ø> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 31418d5...f4041a9. Read the comment docs.

Copy link
Contributor

@masthom masthom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@musicEnfanthen musicEnfanthen merged commit aa70b38 into webern-unibas-ch:develop Jun 4, 2024
8 checks passed
@musicEnfanthen musicEnfanthen deleted the feature/corrections branch June 4, 2024 14:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants