Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(edition): add corrections to source descriptions #1548

Merged
merged 9 commits into from
Jun 4, 2024
Merged

feat(edition): add corrections to source descriptions #1548

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
c8936f4
feat(edition): add corrections to source description
musicEnfanthen Apr 29, 2024
cb014cd
style(app): fix linting errors after update
musicEnfanthen Jun 3, 2024
512193e
refactor(edition): move source description into own module
musicEnfanthen Jun 3, 2024
8144b19
fix(edition): use correct headings for source desc corrections
musicEnfanthen Jun 3, 2024
02ae6cb
refactor(edition): move corrections into separate component
musicEnfanthen Jun 3, 2024
fa2e8e0
fix(assets): add correction ids
musicEnfanthen Jun 3, 2024
32ca1c8
fix(assets): remove unused ids from corrections in op12
musicEnfanthen Jun 3, 2024
dfa2ad3
test(edition): add tests for source description corrections
musicEnfanthen Jun 3, 2024
f4041a9
fix(assets): fix description and link of corrections in m212
musicEnfanthen Jun 4, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions src/app/side-info/edition-info/edition-info.component.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ <h5 id="awg-edition-info-header">{{ editionInfoHeader }}</h5>
class="awg-edition-info-header-link"
[routerLink]="[
editionRouteConstants.EDITION.route,
editionRouteConstants.SERIES.route
editionRouteConstants.SERIES.route,
]"
>{{ editionRouteConstants.SERIES.full }}</a
>
Expand All @@ -26,7 +26,7 @@ <h5 id="awg-edition-info-header">{{ editionInfoHeader }}</h5>
class="awg-edition-info-header-link"
[routerLink]="[
editionRouteConstants.EDITION.route,
editionRouteConstants.ROWTABLES.route
editionRouteConstants.ROWTABLES.route,
]"
>{{ editionRouteConstants.ROWTABLES.full }}</a
>
Expand Down Expand Up @@ -59,7 +59,7 @@ <h5 id="awg-edition-info-header">{{ editionInfoHeader }}</h5>
class="awg-edition-info-header-link"
[routerLink]="[
editionComplex.baseRoute,
editionRouteConstants.EDITION_SHEETS.route
editionRouteConstants.EDITION_SHEETS.route,
]"
>{{ editionTypeConstants.SKETCH_EDITION.full }}</a
>
Expand All @@ -69,7 +69,7 @@ <h5 id="awg-edition-info-header">{{ editionInfoHeader }}</h5>
class="awg-edition-info-header-link"
[routerLink]="[
editionComplex.baseRoute,
editionRouteConstants.EDITION_GRAPH.route
editionRouteConstants.EDITION_GRAPH.route,
]"
>{{ editionRouteConstants.EDITION_GRAPH.short }}</a
>
Expand Down Expand Up @@ -109,7 +109,7 @@ <h5 id="awg-edition-info-header">{{ editionInfoHeader }}</h5>
class="awg-edition-info-header-link"
[routerLink]="[
editionComplex.baseRoute,
editionRouteConstants.EDITION_SHEETS.route
editionRouteConstants.EDITION_SHEETS.route,
]"
>{{ editionTypeConstants.SKETCH_EDITION.full }}</a
>
Expand Down
2 changes: 1 addition & 1 deletion src/app/side-info/resource-info/resource-info.component.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -102,7 +102,7 @@
[ngClass]="{
btn: true,
'btn-outline-success': resourceInfoFormGroup.valid,
'btn-outline-danger': resourceInfoFormGroup.invalid
'btn-outline-danger': resourceInfoFormGroup.invalid,
}"
id="awg-resource-info-input-group-text"
[disabled]="
Expand Down
2 changes: 1 addition & 1 deletion ...a-view/data-outlets/search-panel/fulltext-search-form/fulltext-search-form.component.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@
id="awg-fulltext-search-searchValue"
class="form-control"
[ngClass]="{
'is-invalid': isFulltextSearchInputInvalid()
'is-invalid': isFulltextSearchInputInvalid(),
}"
formControlName="searchvalControl"
[attr.aria-label]="fulltextSearchFormStrings.label"
Expand Down
5 changes: 2 additions & 3 deletions ...ew/edition-outlets/edition-complex/edition-detail/edition-report/edition-report.module.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,8 +3,8 @@ import { NgModule } from '@angular/core';
import { SharedModule } from '@awg-shared/shared.module';

import { EditionTkaModule } from '../edition-tka/edition-tka.module';
import { SourceDescriptionModule } from './source-description/source-description.module';

import { SourceDescriptionComponent } from './source-description';
import { SourceEvaluationComponent } from './source-evaluation';
import { SourceListComponent } from './source-list';
import { TextcriticsListComponent } from './textcritics-list';
Expand All @@ -21,10 +21,9 @@ import { EditionReportRoutingModule, routedEditionReportComponents } from './edi
* {@link SourceDescriptionComponent}, and {@link SourceEvaluationComponent}.
*/
@NgModule({
imports: [SharedModule, EditionTkaModule, EditionReportRoutingModule],
imports: [SharedModule, EditionTkaModule, SourceDescriptionModule, EditionReportRoutingModule],
declarations: [
TextcriticsListComponent,
SourceDescriptionComponent,
SourceEvaluationComponent,
SourceListComponent,
routedEditionReportComponents,
Expand Down
1 change: 1 addition & 0 deletions .../edition-detail/edition-report/source-description/source-description-corrections/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
export * from './source-description-corrections.component';
25 changes: 25 additions & 0 deletions ...-description/source-description-corrections/source-description-corrections.component.html
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,25 @@
<div class="awg-source-description-corrections">
<p class="no-para"><span class="smallcaps">Korrekturen:</span></p>
@for (correction of corrections; track correction.id) {
<details class="half-para awg-source-description-correction-details" [id]="correction.id">
<summary
class="half-para awg-source-description-correction-summary"
[compile-html]="correction.label + ':'"
[compile-html-ref]="ref"></summary>
@for (description of correction.description; track description) {
<p
class="awg-source-description-correction-desc"
[compile-html]="description"
[compile-html-ref]="ref"></p>
}
<awg-edition-tka-table
[textcriticalComments]="correction.comments"
[isCorrections]="true"
[isRowTable]="correction.rowtable"
(navigateToReportFragmentRequest)="navigateToReportFragment($event)"
(openModalRequest)="openModal($event)"
(selectSvgSheetRequest)="selectSvgSheet($event)">
</awg-edition-tka-table>
</details>
}
</div>
Empty file added ...-description/source-description-corrections/source-description-corrections.component.scss
View file
Open in desktop
Empty file.
Loading
Loading