feat: update initializer

webisopen · Dec 24, 2024 · 52d7c62 · 52d7c62
1 parent 6d9fbf2
commit 52d7c62
Show file tree

Hide file tree

Showing 4 changed files with 4 additions and 5 deletions.
diff --git a/src/OVMClient.sol b/src/OVMClient.sol
@@ -61,9 +61,8 @@ abstract contract OVMClient is IOVMClient, AccessControlEnumerable, Initializabl
     /**
      * @dev Initializes the contract by setting up the admin role
      * @param admin The address that will be granted the admin role
-     * @param version The version number for this initialization
      */
-    function initialize(address admin, uint8 version) public reinitializer(version) {
+    function _OVMClient_initialize(address admin) internal {
         _grantRole(ADMIN_ROLE, admin);
     }
 

diff --git a/test/OVMClient.t.sol b/test/OVMClient.t.sol
@@ -18,7 +18,7 @@ contract OVMClientTest is Test {
     function setUp() public {
         mockTasks = new MockOVMGateway();
         ovmClient = new OVMClientImpl(address(mockTasks));
-        ovmClient.initialize(alice, 1);
+        ovmClient.initialize(alice);
     }
 
     function testRequest() public {

diff --git a/test/OVMGateway.t.sol b/test/OVMGateway.t.sol
@@ -38,7 +38,7 @@ contract OVMGatewayTest is Test {
         // Initialize the OVMGateway contract
 
         ovmClient = new OVMClientImpl(address(tasks));
-        ovmClient.initialize(_cfg.templateAdmin(), 1);
+        ovmClient.initialize(_cfg.templateAdmin());
     }
 
     function testRequest() public {

diff --git a/test/mocks/OVMClientImpl.sol b/test/mocks/OVMClientImpl.sol
@@ -16,7 +16,7 @@ contract OVMClientImpl is OVMClient {
     constructor(address OVMGatewayAddress) OVMClient(OVMGatewayAddress) {}
 
     function initialize(address admin) external initializer {
-        super.initialize(admin, 1);
+        super._OVMClient_initialize(admin);
     }
 
     /**