update webos.inc and webos_ls2_api_list.bbclass #32
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…xtraction
:Release Notes:
Modify webos_ls2_api_list.bbclass for LS2 API file path
:Detailed Notes:
Changed ls2_api_list.json file path to use BUILDHISTORY_DIR_IMAGE and
not create this file when buildhistory isn't enabled.
:Testing Performed:
Tested the LS2 API API extraction in local webOS distro builds
:QA Notes:
N/A
:Issues Addressed:
[WRQ-1035] Verify LS2_API_List with build path BUILDHISTORY_DIR_IMAGE
or TMPDIR
Change-Id: I27e8d0f93b27f5f9b03cb83584b5ce71c9ecd4d9
:Release Notes: Unfortunately meta-webos/classes/pkg_dependency.bbclass reads it from packages (.control fils inside rootfs) and fails when 'recipe' field is missing as shown in: http://gecko.lge.com/jenkins/job/webos-master-verify-qemux86-64/10736/ and pkg_dependency is added unconditionally in: meta-webos/classes/pkg_dependency.bbclass:ROOTFS_POSTPROCESS_COMMAND += "create_pkg_dependency_data ;" meta-webos/classes/webos_image.bbclass:IMAGE_CLASSES += "webos_oss_pkg_info pkg_dependency webos_ls2_api_info ${@bb.utils.contains('IMAGE_FEATURES', 'webos-extract-ls2-api', 'webos_ls2_api_list', '', d)}" so another reason to force package_ipk in webos.inc or make these conditional on package_ipk being the first listed in PACKAGE_CLASS. :Detailed Notes: Fixes do_package_write_rpm failures as shown in Yocto AB: https://autobuilder.yoctoproject.org/typhoon/#/builders/163/builds/6 and "bitbake zlib" with "package_rpm" in PACKAGE_CLASSES: http://errors.yoctoproject.org/Errors/Build/177768/ :Testing Performed: Only build tested. :QA Notes: No change to image. :Issues Addressed: [WRQ-10346] CCC: webos.inc: avoid adding user-defined fields to packages Change-Id: I14a1d2f5290b9ac626b4e620a7eed13b7240fb1a
:Release Notes:
Force PACKAGE_CLASSES to IPK to avoid using other package managers
:Detailed Notes:
Currently webOS supports to build with IPK only,
this fix avoids Yocto aubuilder building webOS with RPM/DEB.
Errors when build with package_rpm:
| error: line 480: Invalid version (double separator '-'):1.35.0+0webos3-0webos3-r0webos15: Requires: busybox-dev = 1.35.0+0webos3-0webos3-r0webos15
| Building target platforms: qemux86_64-webos-linux
| Building for target qemux86_64-webos-linux
| WARNING:/home/hieunv/OSE/build-webos/build/tmp-glibc/work/qemux86_64-webos-linux/busybox/1.35.0-r0/temp/run.BUILDSPEC.484994:157 exit 1 from 'rpmbuild --noclean --nodeps --short-circuit --target qemux86_64-webos-linux --buildroot /home/hieunv/OSE/build-webos/build/tmp-glibc/work/qemux86_64-webos-linux/busybox/1.35.0-r0/package --define '_topdir /home/hi eunv/OSE/build-webos/build/tmp-glibc/work/qemux86_64-webos-linux/busybox/1.35.0-r0' --define '_rpmdir /home/hieunv/OSE/build-webos/build/tmp-glibc/work/qemux86_64-webos-linux/busy box/1.35.0-r0/deploy-rpms/qemux86_64' --define '_builddir /home/hieunv/OSE/build-webos/build/tmp-glibc/work/qemux86_64-webos-linux/busybox/1.35.0-r0/busybox-1.35.0' --define '_build_name_fmt %%{NAME}-%%{VERSION}-%%{RELEASE}.%%{ARCH}.rpm' --define '_use_internal_dependency_generator 0' --define '_binaries_in_noarch_packages_terminate_build 0' --define '_build_id_links none' --define '_source_payload w19T64.zstdio' --define'_binary_payload w19T64.zstdio' --define 'clamp_mtime_to_source_date_epoch 1' --define 'use_source_date_epoch_as_buildtime 1' --define '_buildhost reproducible' --define '__font_provides %{nil}' --define '__find_requires %{nil}' --define '__find_provides %{nil}' --define '_unpackaged_files_terminate_build 0' --define 'debug_package %{nil}' --define '_tmppath /home/hieunv/OSE/build-webos/build/tmp-glibc/work/qemux86_64-webos-linux/busybox/1.35.0-r0' -bb /home/hieunv/OSE/build-webos/build/tmp-glibc/work/qemux86_64-webos-linux/busybox/1.35.0-r0/busybox.spec'
:Testing Performed:
See the CCC jira ticket
:QA Notes:
No change to image
:Issues Addressed:
[WRQ-10346] CCC: webos.inc: Force PACKAGE_CLASSES to IPK
Change-Id: I73dc691419f2267c6d3fc201e317719a2c3dffd0
ywbyun0815
pushed a commit
that referenced
this pull request
Nov 5, 2024
…sandstone=r0,v2.9.1 :Release Notes: - Update Enact CLI version 6.1.2, jsdoc-to-ts 1.0.6 Sandstone 2.9.1 - Revert http://gpro.lge.com/c/webos-pro/meta-lg-webos/+/340673 to prevent npm install fails :Detailed Notes: enact-dev-naitve: 6.0.4..6.1.2 53156dd Version value updating 899e2c2 Update a change log for 6.1.2 2c8ebeb Version value updating 68e7a8c Update the release date 3a3c843 WRQ-10036: Update docs for `enact pack` options (#343) 53298ca Update a change log for 6.1.1 0b8460a Version value updating 8c3b661 modify release date d91afee Use the latest cli modules 0bf9e47 Update a change log for 6.1.0 5cd7ecb update node-polyfill-webpack-plugin v3 and remove postcss-safe-parser (#342) d029884 WRQ-200: Remove getCSSModuleLocalIdent and use cssModuleIdent only (#336) 8c30b37 WRQ-214: Fixed `--framework` option to use strict lint rules (#341) 4396878 WRQ-421: Update minor dependencies to fix vulnerabilities (#340) eaa64ee WRQ-240: Merge `feature/unify-eslint-modules` branch to `develop` branch (#338) 18d2fa5 update license (#339) a6b67a8 WRQ-191: Fix the statement to generate unique class names in module css (#335) jsdoc-to-ts-native: 1.0.0..1.0.6 916dee1 Version value updating 9e5ba84 update dependency tree 28b339c Update a change log for 1.0.6 3d6a5bb WRQ-25865: Updated package dependencies to fix security vulnerabilities (#41) 1e5dc56 Version value updating 5a91339 Update a change log for 1.0.5 fb3d031 WRQ-10328: Removed `chai` and `mocha` libraries (#38) d017929 WRQ-16518: Updated jsonata dependency and updated package-lock to fix vulnerabilities (#39) 141c75f Version value updating 720868e Update a change log for 1.0.4 c2d4a8d updated `chai` to v.^5.0.3 (#37) e49ea4b updated dependencies to fix vulnerabilities (#36) 3da25c0 Version value updating 7e102bc Update a change log for 1.0.3 e837cc2 updated dependencies (#35) eca771d update dependencies to the latest minor version (#34) f41fb77 Version value updating d5f354d Update a change log for 1.0.2 Enact-DCO-1.0-Signed-off-by: SJ RO (sj.ro@lge.com) 133371a update minor dependencies (#31) b32c993 update prettier releated modules (#32) 2b09a24 Version value updating 2d7c183 Update a change log for 1.0.1 7040d6e WRP-21114: Generated ts file is empty if a module is marked as private (#30) 8779dcb WRP-19328: Updated glob dependency to the latest major version (#29) b718a00 Update a README.md Enact-DCO-1.0-Signed-off-by: SJ RO (sj.ro@lge.com) ba76824 Update a README.md Enact-DCO-1.0-Signed-off-by: SJ RO (sj.ro@lge.com) enact-sandstone: 2.7.3..2.9.1 eebf3a42 Version value updating 6fca3105 Update dependencies and sampler version to 2.9.1 d76679de Update change logs for 2.9.1 78ff2bff WRQ-31515: Fixed `Scroller`, `Slider`, `VirtualList` and `VirtualGridList` to set prop value to default when `undefined` is passed for the prop value (#1658) 7bc3b365 WRQ-22396: Refactoring Steps and update QuickGuidePanels sampler (#1677) f9dc8d28 Add new icons (#1674) 8eec1616 WRQ-27436: Added public classes to expand size of title and content in Alert (#1665) b38a013c Version value updating 8493db1e Update dependencies and sampler version to 2.9.0 ed3b1662 Update change logs for 2.9.0 0365e065 WRQ-28258: Update dependencies' minor version (#1637) a58e5800 WRQ-9660: Updated samples to use `useReducer` rather than redux (#1572) 4486fa8f WRQ-23782: Add missing ui/ss tests Panels --> WizardPanels (#1634) c80253a3 WRQ-28743: Storybook - Read custom colors/presets from luna settings service (#1638) 77c95f75 WRQ-15921: Fix `Popup` to not focus the element of the popup container when popup is hidden (#1604) c9c4d779 WRQ-23779: Added missing ui/ss tests (#1630) a3c11252 WRQ-27016: Fix PageViews styling as GUI guide (#1635) eacb461b WRQ-7108: Remove unnecessary vendor prefixes (#1609) 1a6e4bd3 WRQ-24303: Add marqueeController with content changed samples in marquee qa-sampler (#1633) a15036d4 WRQ-24170: Fixed VirtualGridList qa sampler by passing args as a prop (#1631) 374ab6be WRQ-25442: Fixed Editable Scroller to blur the focused item properly (#1629) 38c28349 WRQ-18295: Reactivate skipped ui-tests. (#1601) 82aea9f6 WRQ-8429: Fixed back button not to work when disabled is set to true on `Input` component (#1600) d9f5d548 Version value updating c6334f0f Update dependencies and sampler version to 2.9.0-beta.1 1a260d0c Update change logs for 2.9.0-beta.1 975ab2da Add new icon `create` (#1625) aba3d8b0 WRQ-7995: Clean up unnecessary code to cancel back key behavior by app scenarios (#1621) 0e738c18 WRQ-16694: Updated `ui-tests` to use `expect` from jest (#1592) a4249bf0 Version value updating a5de475b Update dependencies and sampler version to 2.9.0-alpha.4 fe084c3b Update change logs for 2.9.0-alpha.4 a05e502b WRQ-19324: Fix `ContextualPopupDecorator` and `DropdownList` to add sibling DOM node using WithRef instead of adding sibling DOM node manually. (#1623) f0d0636a WRQ-19325: Updated DateTime's internal style to work with changed DOM structure of Spottable (#1622) 58ef8c23 WRQ-19324: Remove findDOMNode in Dropdown and ContextualPopupDecorator (#1607) 400b88cd WRQ-22257: Fixed an issues where FixedPopupPanels were always full height when in high contrast mode (#1620) b70a48a6 WRQ-18856: PageViews: Hide indicator when there is only one page (#1606) 0bd8f169 Version value updating dfe7825e Update a change log for 2.9.0-alpha.3 a588754a Update dependencies and sampler version to 2.9.0-alpha.3 ac617f46 update storybook-utils v5.1.4 505b79a3 WRQ-20241: Fix `QuickGuidePanels` to export `Panel` instead of `QuickGuidePanel` (#1615) a12fc66b WRQ-19328: Fix React 18.3 warnings in sandstone (#1613) 32fd77f9 WRQ-20013: Add new wifi5g icons (#1612) cbf2696f WRQ-17937: Add `fullContents` prop in PageViews (#1614) d2d4a7f7 WRQ-17933: Add changelog for QHD support (#1608) 612b1672 WRQ-17933: Support QHD resolution (#1596) c6a43dc1 WRQ-18301: Fix failed ui-test on jenkins(TabLayout) (#1595) b2836b19 WRQ-18041: Fix TabLayout to move focus to the tab menu when it is in panels (#1597) 9b7504ea Update .travis.yml to avoid node 22 error temporarily (#1603) 628300a7 Version value updating 992853e3 Update a change log for 2.9.0-alpha.2 82728598 WRQ-14896: Add focus highlight mode (#1591) dd4f9f9a Fix PageViews style (#1593) 3fe3f7c9 WRQ-17937: Fix QuickGuidePanels screenshot test (#1594) f154742e Version value updating 1c964545 Update dependencies and sampler to use enact 4.9.0-alpha.1 d8a5cf6b update release date for 2.9.0-alpha.1 7861deba WRQ-420: Separate WizardPanels and QuickGuidePanel (#1567) 3fb692f8 Fix ilib version to 14.19.0 (#1589) 81dd2d41 Update change logs for 2.9.0-alpha.1 2daf6871 WRQ-14550: Fix isomorphic error in PageViews (#1586) 33731ad5 WRQ-10227: Updated high-contrast mode to match with the latest design (#1581) 0a5bc629 WRQ-14550: Add PageViews component (#1582) 7a43c1e2 WRQ-13128: Update minor dependencies to fix vulnerabilities (#1580) 1c5ce747 WRQ-6498: Remove LS2Request call from theme library (#1576) 051827e6 WRQ-5675: Support to set playback speed on video player (#1546) 367f3b30 updated placeholder image URLs (#1575) 310ec16b WRQ-4796: Add comment to Dropdown qa-a11y (#1578) 3cbcf50c WRQ-11311: Increase ui and screenshot tests (#1565) 18f272e8 WRQ-188: Fix the coordinateCoefficient logic on ltr (#1573) 90f9dc5a WRQ-6229: Add ContentContainerDecorator and update calculateAndScrollTo logic in useScroll/useEvent.js (#1571) 1975c88a WRQ-6220: Fixed `VirtualList` to show the focused item properly when switching from pointer mode to 5-way mode (#1566) 99b0b8ee WRQ-11772: Fixed `VirtualList` to show the focused item properly when focus moved toward on unscrollable direction (#1569) adbed141 WRQ-188: Update internal calls to the updated core/platform APIs (#1559) 2b2a3c63 Update @enact/docs-utils version to ^0.4.8 in package.json file (#1568) 1e2f0729 WRQ-10752: Fix failed ui test on Jenkins (PopupTabLayout) (#1560) aaa0c842 Version value updating bfa8dfe1 Update a change log for 2.8.0 cd333ef2 Update dependencies and sampler to use enact 4.8.0 13495034 WRQ-7861: Added if options to the maxLength and minLength controls in the sampler of the input component (#1554) 6cf0adf6 WRQ-8428: Sync up ui/screenshot tests and test cases. (#1548) 38baf8bf Update dependencies and sampler version to 2.8.0 5786c8de WRQ-7224: Fixed `Scroller` to stop propagation of 'keyup' event when back key moves focus inside a scroller (#1551) 586de1e9 WRQ-8636: Fix editable scroller to remain focus in selected item when editing complete with 4-way key in pointer mode (#1550) 1ed00848 update dependencies (#1553) 4569970a WRQ-7951: Modify big buck bunny video url. (#1545) 4c1a0950 WRQ-171: Fix `VirtualList` to have proper scroll position when item with affordance is larger than scroll area (#1529) 51a961f7 WRQ-6835: Fix editable scroller qa-sampler to not show label of items… (#1541) e0cf9df6 WRQ-7944: Update docs for the default value of Panels/Header.marqueeOn (#1543) dd3917b8 WRQ-202: Implement editing items in touch mode (#1534) 3746ed81 WRQ-421: Update minor dependencies to fix vulnerabilities (#1537) 821529e5 WRQ-7338: Fix unknown prop warning in TabLayout (#1538) 05dac8cd update license (#1536) 96400479 Update 'update-copyright-years.yml' to change triggering date to Jan 4 for copyright update (#1535) dca0c745 Update 'update-copyright-years.yml' to change triggering date to Jan 4 for copyright update (#1535) bd902712 WRQ-156: [Codecov] Increase coverage for editable scroller (#1532) 28fe8115 Version value updating f29ca6f7 Update a change log for 2.7.13 Enact-DCO-1.0-Signed-off-by: SJ RO (sj.ro@lge.com) bfd2c0fb Update dependencies and sampler version to 2.7.13 Enact-DCO-1.0-Signed-off-by: SJ RO (sj.ro@lge.com) 1fce9ac3 Update qa-a11y tablayout view (#1528) e23a5b67 WRQ-4832: Fix failed ui test on Jenkins(QuickGuidePanels) (#1527) 9f5f13e4 WRQ-2636: Fixed Scroller with editable to rearrange items properly when moving pointer very fast (#1524) d31828bf WRQ-1307: Update audio guidance of TabLayout component (#1526) 792af042 WRQ-4089: Update audio guidance of Slider component (#1525) 35a9010a WRQ-1308: Update audio guidance of Dropdown component (#1519) 683867e2 WRQ-3732: Fixed Scroller with editable prop to complete editing when focus is leaving by 5-way key on pointer mode (#1522) c41f08ba WRQ-155: Update `Scroller` to complete editing by 'down' key when `editable` is given (#1518) 619321f0 WRQ-1306: Change back key behavior on TabLayout to navigate focus from tab contents to tab menu (#1516) e8031636 WRQ-3746: Fix failed ui test on jenkins(VirtualList) (#1517) 3afda4fb WRQ-415: Update minor dependencies to fix vulnerabilities (#1514) 980cb483 WRP-24613: Added UI tests for Editable Scroller (#1508) 77b1fca9 Version value updating 7b1cd0af Update a change log for 2.7.12 Enact-DCO-1.0-Signed-off-by: SJ RO (sj.ro@lge.com) ae4a3329 Update .travis.yml to avoid node 21 error temporarily Enact-DCO-1.0-Signed-off-by: SJ RO (sj.ro@lge.com) bfddabc5 WRQ-456: Apply GA and cookie banner only when there is a relevant environment variable (#1513) ff2b075f WRQ-379: Fix EditableWrapper movement completion announcement (#1512) b6fe32e1 WRP-27429 : Update to apply google analytics 4 to sampler (#1507) e1157d79 WRP-17963: [sandstone] Add ui-test for editable scroller (#1510) 65f5630a Version value updating 43111fae Update a change log for 2.7.11 Enact-DCO-1.0-Signed-off-by: SJ RO (sj.ro@lge.com) b618c4e1 Update sampler version to 2.7.11 Enact-DCO-1.0-Signed-off-by: SJ RO (sj.ro@lge.com) 45c304b0 Revert back key behavior of TabLayout that moves focus from tab content to tab menu (#1495, #1505) (#1511) 928eda3d WRP-29597: Add PopupTabLayout UI test (#1509) 645cf06a Version value updating 7c2c7a41 Update a change log for 2.7.10 Enact-DCO-1.0-Signed-off-by: SJ RO (sj.ro@lge.com) 4d384096 Update dependencies and sampler version to 2.7.10 Enact-DCO-1.0-Signed-off-by: SJ RO (sj.ro@lge.com) f874f5b7 WRP-27860: Fix `EditableScroller` to check validity of initial selected item info (#1506) 0eda6836 WRP-27604: Fix `VirtualList` not to snatch focus from other list (#1503) 18be3d73 WRP-27786: Fix `TabLayout` to ignore back key behavior in cursor mode (#1505) a85a863b WRP-25755: [Sandsonte Samples] qa-a11y: Add new component from sandst… (#1504) 83288066 Version value updating ad743c97 Update a change log for 2.7.9 Enact-DCO-1.0-Signed-off-by: SJ RO (sj.ro@lge.com) 5ad9323e Update dependencies and sampler version to 2.7.9 Enact-DCO-1.0-Signed-off-by: SJ RO (sj.ro@lge.com) fe46cd9f WRP-26318: Fix editable scroller a11y feature to not cut off panel's audio guidance (#1502) 0c9107d4 update dependencies (#1498) 8ed2fe56 WRP-23228: Changed back key behavior on TabLayout (#1495) d90fdc34 Fix TabLayout to handle focus properly after pressing enter key (#1500) bc950e4f WRP-27297: `Panels.Header` to not show `slotAfter` in incorrect position at first rendering when `centered` is given (#1501) 68306a52 WRP-26268: Rename PalmServiceBridge as WebOSServiceBridge (#1499) c3461241 WRP-26288: Passed noAnimation prop to Popup inside sandstone/colorPicker (#1497) 82573831 WRP-24606: Fix hint dialog position of About page in the Sampler (#1490) 605cf4d8 Version value updating 1a844c58 Update a change log for 2.7.8 Enact-DCO-1.0-Signed-off-by: SJ RO (sj.ro@lge.com) bf48bbda Update dependencies and sampler version to 2.7.8 Enact-DCO-1.0-Signed-off-by: SJ RO (sj.ro@lge.com) 98ed368e WRP-25779: Fix `Scroller` to support RTL locales when `editable` is given (#1493) f42fb5b0 Add screenshot test (#1494) ef8afe14 WRP-23104: Update `IconItem` color when disabled (#1492) 97b1ca60 WRP-25233: Fix QuickGuidePanels to focus the last focused button (#1491) de42ca22 WRP-24617: Fix ui test fail on jenkins(VirtualList) (#1485) 6e6bbdd2 Version value updating 97082cf9 Update a change log for 2.7.7 Enact-DCO-1.0-Signed-off-by: SJ RO (sj.ro@lge.com) 14074a00 Update sampler version to 2.7.7 Enact-DCO-1.0-Signed-off-by: SJ RO (sj.ro@lge.com) f84b59b3 WRP-24016: Update sampler for EditableScroller (#1489) 398e3ca1 WRP-24016: Fixed unexpected focus lose when 'cancel' key is pressed (#1488) 809cd1c6 WRP-24596: Fix EditableScroller to allow hiding all items (#1487) fb657db0 WRP-23234: Add a11y feature for sandstone/QuickGuidePanels (#1486) a03155ce Version value updating 407349b0 Update a change log for 2.7.6 Enact-DCO-1.0-Signed-off-by: SJ RO (sj.ro@lge.com) 8d6abaab Update dependencies and sampler version to 2.7.6 Enact-DCO-1.0-Signed-off-by: SJ RO (sj.ro@lge.com) dd17c206 WRP-22351: Publish the ColorPicker component (#1479) 64ba56a8 WRP-21312: change enter key behavior to match the latest UX (#1476) 8341024b Update phrase of editable scroller a11y (#1484) 5622dbbd WRP-22553: Fix Dropdown to focus properly the first option and the last option via page up and page down (#1483) 7aa2e985 WRP-21913: Fix QuickGuidePanels to not lose focus when the last view is displayed (#1482) 917ec7ba WRP-20670: Support A11y for Editable scroller according to the latest UX (#1481) c24c13d8 WRP-21684: Support apps to show arrow only for moveable direction (#1480) 419158aa Version value updating c688049e Update a change log for 2.7.5 Enact-DCO-1.0-Signed-off-by: SJ RO (sj.ro@lge.com) 54480c71 Update sampler version to 2.7.5 Enact-DCO-1.0-Signed-off-by: SJ RO (sj.ro@lge.com) c57b6526 WRP-21680: Add initialSelected prop in `editable` prop of scroller (#1478) d11dbbec WRP-22023: Support 'back' key to escape selection mode in EditableScroller (#1477) 442e5af5 WRP-21715: Fix `sandstone/EditableWrapper` to handle focus properly (#1475) 7afe88d2 WRP-21706: Fixed `sandstone/VirtualList` to move focus properly by 5-way directional key hold (#1474) c155237e WRP-21653: Fix ui-test fail on jenkins(PopupTabLayout). (#1472) cf1c2f9d Version value updating 0aa70e6e Update a change log for 2.7.4 Enact-DCO-1.0-Signed-off-by: SJ RO (sj.ro@lge.com) 8a51985e Update sampler version to 2.7.4 Enact-DCO-1.0-Signed-off-by: SJ RO (sj.ro@lge.com) d879583f WRP-21338: Fixed `VirtualGridList` to not apply a scale effect to outside DOM when `snapToCenter` is given (#1471) :Testing Performed: Verf built and locally tested :QA Notes: N/A :Issues Addressed: [WRR-3572] CCC: enact-dev-native=r0,v6.1.2 jsdoc-to-ts-native=r0,v1.0.6 enact-sandstone=r0,v2.9.1 [WRR-777] [CCC] Update CLI and Framework to RP Cherry-picked-from-commit: 025bb26f9bb926fe8079c78dfdd114dcbe59b76d Cherry-picked-from-branch:
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR includes 2 parts: