Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor review #220

Merged
merged 16 commits into from
Jun 27, 2023
Merged

Refactor review #220

merged 16 commits into from
Jun 27, 2023

Conversation

BennyThink
Copy link
Member

Don't merge it unless you want some surprise

Review Guide

  • resolve or explain every line with TODO

@BennyThink BennyThink requested a review from n0vad3v May 30, 2023 18:23
@github-actions
Copy link 


ghcr.io/webp-sh/webp_server_go (debian 11.7)
============================================
Total: 0 (HIGH: 0, CRITICAL: 0)

@n0vad3v n0vad3v mentioned this pull request Jun 10, 2023
Closed
@github-actions
Copy link 


ghcr.io/webp-sh/webp_server_go (debian 12.0)
============================================
Total: 0 (HIGH: 0, CRITICAL: 0)

@BennyThink
fix #234
c1ddabb 
2: 5.9s - 7.6MB
4: 26s - 6.9MB
@github-actions
Copy link 


ghcr.io/webp-sh/webp_server_go (debian 12.0)
============================================
Total: 0 (HIGH: 0, CRITICAL: 0)

@github-actions
Copy link 


ghcr.io/webp-sh/webp_server_go (debian 12.0)
============================================
Total: 0 (HIGH: 0, CRITICAL: 0)

1 similar comment
@github-actions
Copy link 


ghcr.io/webp-sh/webp_server_go (debian 12.0)
============================================
Total: 0 (HIGH: 0, CRITICAL: 0)

@BennyThink BennyThink mentioned this pull request Jun 26, 2023
Closed
@github-actions
Copy link 


ghcr.io/webp-sh/webp_server_go (debian 12.0)
============================================
Total: 0 (HIGH: 0, CRITICAL: 0)

@github-actions
Copy link 


ghcr.io/webp-sh/webp_server_go (debian 12.0)
============================================
Total: 0 (HIGH: 0, CRITICAL: 0)

1 similar comment
@github-actions
Copy link 


ghcr.io/webp-sh/webp_server_go (debian 12.0)
============================================
Total: 0 (HIGH: 0, CRITICAL: 0)

@BennyThink BennyThink merged commit 23bbed8 into master Jun 27, 2023
@BennyThink BennyThink deleted the refactor_package branch June 27, 2023 13:43
@github-actions
Copy link 


ghcr.io/webp-sh/webp_server_go (debian 12.0)
============================================
Total: 0 (HIGH: 0, CRITICAL: 0)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@n0vad3v n0vad3v n0vad3v approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@BennyThink @n0vad3v