Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(externals): add import and module-import external type #7345

Merged
merged 4 commits into from
Aug 24, 2024

Conversation

fi3ework
Copy link
Contributor

@fi3ework fi3ework commented Aug 5, 2024

Update doc for webpack/webpack#18620.

fixes #7348

  • Read and sign the CLA. PRs that haven't signed it won't be accepted.
  • Make sure your PR complies with the writer's guide.
  • Review the diff carefully as sometimes this can reveal issues.
  • Do not abandon your Pull Request: Stale Pull Requests.
  • Remove these instructions from your PR as they are for your eyes only.

Copy link

vercel bot commented Aug 5, 2024

@fi3ework is attempting to deploy a commit to the Webpack Docs Team on Vercel.

A member of the Team first needs to authorize it.

alexander-akait
alexander-akait previously approved these changes Aug 5, 2024
src/content/configuration/externals.mdx Outdated Show resolved Hide resolved
src/content/configuration/externals.mdx Outdated Show resolved Hide resolved
src/content/configuration/externals.mdx Outdated Show resolved Hide resolved
src/content/configuration/externals.mdx Outdated Show resolved Hide resolved
src/content/configuration/externals.mdx Outdated Show resolved Hide resolved
src/content/configuration/externals.mdx Outdated Show resolved Hide resolved
Copy link

vercel bot commented Aug 24, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
webpack-js-org ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 24, 2024 11:12am

Copy link
Member

@snitin315 snitin315 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@snitin315 snitin315 merged commit 7729b52 into webpack:main Aug 24, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Document webpack change: feat: add new external type "module-import"
3 participants