Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs(optimization): add optimization.avoidEntryIife #7402

Merged
merged 6 commits into from
Sep 29, 2024
Merged

docs(optimization): add optimization.avoidEntryIife #7402

merged 6 commits into from
Sep 29, 2024

Conversation

fi3ework
Copy link
Contributor

Doc for webpack/webpack#18772.

  • Read and sign the CLA. PRs that haven't signed it won't be accepted.
  • Make sure your PR complies with the writer's guide.
  • Review the diff carefully as sometimes this can reveal issues.
  • Do not abandon your Pull Request: Stale Pull Requests.
  • Remove these instructions from your PR as they are for your eyes only.

@vercel Vercel
Copy link

vercel bot commented Sep 19, 2024

@fi3ework is attempting to deploy a commit to the Webpack Docs Team on Vercel.

A member of the Team first needs to authorize it.

@fi3ework fi3ework mentioned this pull request Sep 19, 2024
Merged
@fi3ework fi3ework changed the title docs(optimization): add optimization.entryIife docs(optimization): add optimization.avoidEntryIife Sep 25, 2024
@vercel Vercel
Copy link

vercel bot commented Sep 25, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
webpack-js-org ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 26, 2024 6:21am

chenxsan
chenxsan reviewed Sep 25, 2024
View reviewed changes
src/content/configuration/optimization.mdx Show resolved Hide resolved
src/content/configuration/optimization.mdx Outdated Show resolved Hide resolved
src/content/configuration/optimization.mdx Outdated Show resolved Hide resolved
fi3ework and others added 3 commits September 26, 2024 11:41
@fi3ework @chenxsan
Update src/content/configuration/optimization.mdx
24f7dfd 
Co-authored-by: Sam Chen <chenxsan@gmail.com>
@fi3ework @chenxsan
Update src/content/configuration/optimization.mdx
6f239ea 
Co-authored-by: Sam Chen <chenxsan@gmail.com>
@fi3ework @chenxsan
Update src/content/configuration/optimization.mdx
9f312b2 
Co-authored-by: Sam Chen <chenxsan@gmail.com>
snitin315
snitin315 approved these changes Sep 29, 2024
View reviewed changes
Copy link
Member

@snitin315 snitin315 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@snitin315 snitin315 merged commit 1c487be into webpack:main Sep 29, 2024
8 checks passed
chenxsan added a commit to chenxsan/webpack that referenced this pull request Sep 30, 2024
@chenxsan
fix: use needs to align with document
f7c5ffd 
webpack/webpack.js.org#7402 (comment)
@chenxsan chenxsan mentioned this pull request Sep 30, 2024
Closed
@snitin315 snitin315 mentioned this pull request Oct 12, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chenxsan chenxsan chenxsan left review comments

@snitin315 snitin315 snitin315 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@fi3ework @chenxsan @snitin315