Introduce global app language lookup #356
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This introduces a global application language lookup, which allows to access the current language in a static manner from normal JS-/ES- resources, without being in a Vue component.
sronveaux
approved these changes
Nov 13, 2023
There was a problem hiding this comment.
Hi @chrismayer,
Just tested the PR as requested and it works flawlessly as expected. Just two small remarks here:
- Shouldn't this be explained in the docs somewhere ? This is perhaps something more global than just linked to this specific PR as the other globals aren't documented neither (thinking about
$appConfig,$map,$isEmbeddedandcmpLookup) and could be addressed later in an issue. This would imply to define which are defined for private use only and which ones would be considered as public API... - Perhaps more important, shouldn't the global be renamed to something like
$appLanguageto follow Vue recommended best practices ?
Just take a second to think about those two and whether something should be done, other than that, it's ready to merge on my point of view !
|
@sronveaux You're totally right, I changed Documentation of this global prop I would tackle in a separate step by generally documenting the global properties. With also taking some thoughts on which one should be usable by devs and which not (as already stated by you). I created an issue for that => #376 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces a global application language lookup
Vue.prototype.appLanguage, which allows to access the current language in a static manner from normal JS-/ES- resources, without being in a Vue component.