Portuguese translation of wegue #378
Conversation
There was a problem hiding this comment.
Thanks @wljrodrigues for your translation! Very much appreciated 👍
The files within the app/ folder are not thought to be committed to the main Wegue repository. It is reserved for the code of your custom Wegue application. The application inside the app/ folder is filled by the npm-task init:app based on the app-starter/ folder.
So before merging this, your PR needs to be cleaned up, so the app/ folder is no more part of the changes. When you revert app/.gitignore you shouldn't even be able to commit the content of the app folder. This is by design.
Would you please do this cleanup @wljrodrigues? Would be very nice. Afterwards I'd happily merge this. If you need some help ping us here.
|
Update complete: The ".gitignore" file in the "app/" directory has been restored to its original state, and the files in the "app/" folder have been cleaned up according to the instructions. I will proceed with creating the PR now. Thanks for your attention! |
There was a problem hiding this comment.
Thanks for your ongoing effort @wljrodrigues. I fear this needs some more love, but we are close ;-)
- please check my inline comments
npm run lintgives 3 errors, which need to be fixed. You can run that command locally to reproduce and check everything is fines before pushing commits- please also run
npm run testbefore pushing your commits
app-starter/locales/pt.json
Outdated
| "text": "Olá Wegue" | ||
| } | ||
| } | ||
|
|
There was a problem hiding this comment.
Please add a blank line at the end of the file
src/locales/pt.json
Outdated
| "wgu-themeswitcher": { | ||
| "title": "Modo Escuro" | ||
| } | ||
| } |
There was a problem hiding this comment.
Please add a blank line at the end of the file
|
@chrismayer Thank you very much for the guidance. I have completed the requested procedures and am now submitting the corrected version for the PR. |
|
@wljrodrigues the tests in CI pipeline are still failing. I created a Pull Request against your changeset wljrodrigues#1, which fixes the tests. If you're happy with my PR please merge it and then this PR should be good to go. |
Fix Locale tests for new Portuguese translation
There was a problem hiding this comment.
Thanks again for providing this @wljrodrigues and for your ongoing effort based on the reviews 👍
@chrismayer thank you very much for the valuable guidance🤝 |
|
Thanks to @wljrodrigues for this one, it's true that adding some translations could potentially augment Wegue visibility in the end... @chrismayer, do you want me to provide some french translations when I'll have a little time ? |
|
@sronveaux sure, would be great. Looking forward... |
Portuguese translation of wegue.