Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow switching base layer by keyboard (ENTER) #383

Merged
merged 1 commit into from
Apr 25, 2024
Merged

Allow switching base layer by keyboard (ENTER) #383

merged 1 commit into from
Apr 25, 2024

Conversation

chrismayer
Copy link
Collaborator

This enables the switch of the map's base layer in the BgLayerSwitcher component by hitting the ENTER key instead of clicking only.

@chrismayer
Allow switching base layer by keyboard (ENTER)
245216e 
This enables the switch of the map's base layer in the BgLayerSwitcher
component by hitting the ENTER key instead of clicking only.
sronveaux
sronveaux approved these changes Apr 25, 2024
View reviewed changes
Copy link
Collaborator

@sronveaux sronveaux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A simple one-liner that indeed improves accessibility in Wegue.

It works flawlessly and LGTM. Ready to merge !

@chrismayer
Copy link
Collaborator Author

Thanks for your review @sronveaux.

@chrismayer chrismayer merged commit 743abc3 into wegue-oss:master Apr 25, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sronveaux sronveaux sronveaux approved these changes

@JakobMiksch JakobMiksch Awaiting requested review from JakobMiksch

@fschmenger fschmenger Awaiting requested review from fschmenger

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@chrismayer @sronveaux