Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prepare workshop for upcoming v2.0.0 #389

Merged
merged 1 commit into from
May 16, 2024

Conversation

chrismayer
Copy link
Collaborator

This prepares the Wegue workshop for the upcoming version 2.0.0. Also corrects some minor issues.

I also went through the workshop and it is still functional with the new future version.

Copy link
Collaborator

@sronveaux sronveaux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @chrismayer,

Good thing, you managed to spot things I missed when doing #361 and some changed texts are clearer now !

There is one thing that would deserve to be fixed in the workshop I think (but in another PR) as we finish the "Use a module" part with a modified theme (pink borders and footer texts changed) then do the "Custom functionality" part as if we didn't make those changes and didn't add the layers and zoom-to-max-extent modules to eventually get to the "Add a custom module" part which resumes as if "Custom functionality" didn't exist...
I tried to find how changes could be minized at that time and think we could address this by taking new screenshots for the "Custom functionality" part and change the beginning text of "Add a custom module" with something like So far we modified the functionality of Wegue using the configuration file or by writing code into WguApp.vue. Now we will create a custom module using JavaScript. First we will revert what was made in WguApp.vue in the previous section. Then, to effectively create the custom module, we need to change a couple of files:

This is only some thoughts about something that could be addressed later though... concerning this specific PR, it LGTM and is ready to merge !

@chrismayer
Copy link
Collaborator Author

Thanks for your review and feedback @sronveaux 👍 I created an issue based on your comment. So we can tackle this later and will not be forgotten...

@chrismayer chrismayer merged commit 0ce4ec0 into wegue-oss:master May 16, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants