Fix hoverable WMS layers. #396
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sronveaux
approved these changes
Jun 5, 2024
There was a problem hiding this comment.
Wow, it is so obvious that it stayed buggy for such a long time...
I fully tried it, the hardest part for me was to find a public WMS server that replied with GML... I must admit I never used some beforehand...
I can confirm that everything works as expected ! This should be ready to merge !
chrismayer
approved these changes
Jun 5, 2024
There was a problem hiding this comment.
Nice catch @fschmenger 👍
I tested and it works now as expected. Thank you very much.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hoverable WMS layers didn`t work because the respective properties were accidently forwarded to the source instead of the layer. It seems that this bug has been around ever since the first implementation.