Unregister events properly inside AttributeTable component #405
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Tests now pass thanks to @chrismayer's celerity with #406 ! |
chrismayer
approved these changes
Jun 20, 2024
There was a problem hiding this comment.
Thanks for this improvement @sronveaux 👍
Please merge at will...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR cleanly unregisters the two events that are used inside the AttributeTable component.
One event is called when a feature is selected on the map. This was still registered after the component was closed...
The second is called when the 'onchange' event of the selected layer is fired. This was not cleanly unregistered when changing layers, so selecting a feature of the previously selected layer continued to fire this event and stayed even after the component was closed.
Should be fixed now...