Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

generate outputMappings #90

Closed
wants to merge 83 commits into from
Closed

generate outputMappings #90

wants to merge 83 commits into from

Conversation

techloghub
Copy link
Collaborator

No description provided.

@techloghub techloghub changed the title add todo mark generate outputMappings Oct 16, 2024
@codecov Codecov
Copy link

codecov bot commented Oct 16, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 76.65198% with 53 lines in your changes missing coverage. Please review.

Project coverage is 35.89%. Comparing base (7b981e0) to head (6a6af2b).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
...w/service/strategies/CustomDAGProcessStrategy.java 83.55% 9 Missing and 16 partials ⚠️
...o/rill/flow/service/manager/DescriptorManager.java 0.00% 10 Missing ⚠️
...traversal/mappings/JSONPathInputOutputMapping.java 79.41% 2 Missing and 5 partials ⚠️
...weibo/rill/flow/olympicene/core/model/dag/DAG.java 0.00% 2 Missing ⚠️
.../rill/flow/service/facade/DAGDescriptorFacade.java 33.33% 2 Missing ⚠️
...ibo/rill/flow/service/facade/DAGRuntimeFacade.java 0.00% 2 Missing ⚠️
...ll/flow/olympicene/core/model/task/ChoiceTask.java 0.00% 1 Missing ⚠️
...rill/flow/olympicene/core/model/task/PassTask.java 0.00% 1 Missing ⚠️
...ll/flow/olympicene/core/model/task/ReturnTask.java 0.00% 1 Missing ⚠️
.../flow/olympicene/core/model/task/SuspenseTask.java 0.00% 1 Missing ⚠️
... and 1 more
Additional details and impacted files 
@@             Coverage Diff              @@
##               main      #90      +/-   ##
============================================
+ Coverage     34.74%   35.89%   +1.15%     
- Complexity      934     1004      +70     
============================================
  Files           187      190       +3     
  Lines          7927     8124     +197     
  Branches        675      706      +31     
============================================
+ Hits           2754     2916     +162     
- Misses         4974     4989      +15     
- Partials        199      219      +20

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Oct 16, 2024

Quality Gate Passed Quality Gate passed

Issues
1 New issue
0 Accepted issues

Measures
0 Security Hotspots
83.9% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

zeyu10 added 23 commits October 16, 2024 16:33
add the situation that contains dot in mapping elements
c3bc1da
remove useless variable
1f0b816
optimit code
638ee3b
adapt v2.0 when get descriptors
2918395
adapt v2.0 when get descriptors
7cc01d4
remove context keyword in v2.0 version
ff5a68a
process inputMappings when set and get descriptor
e48f401
fix index error in processInputMappingsWhenGetDescriptor and add unit…
03442df 
… test
optimit code
a8ea584
add input keyword to generate inputMappings and outputMappings
70a27d7
fix unit test
4d66de3
not limit version
a84e51a
remove useless variable
d7384f5
optimit code
558d063
generate end pass task
0bf14af
generate end pass task
3a551e4
fix unit test
1dfa9ad
fix unit test
7a6000f
fix sonar
a8ff214
fix sonar
e5fe076
change endtaskname
1b2d113
add unit test for generating end pass task
2181dfd
optimit code
66a026d
qdaxb
qdaxb reviewed Oct 24, 2024
View reviewed changes
...w-service/src/main/java/com/weibo/rill/flow/service/strategies/CustomDAGProcessStrategy.java Show resolved Hide resolved
.../src/test/groovy/com/weibo/rill/flow/service/strategies/DefaultDAGProcessStrategyTest.groovy Show resolved Hide resolved
.../src/test/groovy/com/weibo/rill/flow/service/strategies/DAGProcessStrategyContextTest.groovy Show resolved Hide resolved
...ow-service/src/test/groovy/com/weibo/rill/flow/service/statistic/DAGSubmitCheckerTest.groovy Show resolved Hide resolved
...ervice/src/test/groovy/com/weibo/rill/flow/service/statistic/DAGResourceStatisticTest.groovy Show resolved Hide resolved
...-service/src/main/java/com/weibo/rill/flow/service/strategies/DAGProcessStrategyContext.java Outdated Show resolved Hide resolved
...-service/src/main/java/com/weibo/rill/flow/service/strategies/DAGProcessStrategyContext.java Show resolved Hide resolved
rill-flow-service/src/main/java/com/weibo/rill/flow/service/manager/DescriptorManager.java Outdated Show resolved Hide resolved
.../main/java/com/weibo/rill/flow/olympicene/traversal/mappings/JSONPathInputOutputMapping.java Show resolved Hide resolved
.../main/java/com/weibo/rill/flow/olympicene/traversal/mappings/JSONPathInputOutputMapping.java Show resolved Hide resolved
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Oct 24, 2024

Quality Gate Passed Quality Gate passed

Issues
1 New issue
0 Accepted issues

Measures
0 Security Hotspots
81.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@techloghub techloghub closed this Oct 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@qdaxb qdaxb qdaxb left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@techloghub @qdaxb