Filter cosmetic variants of monsters #509
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Here is the list of mobs currently filtered by purely matching monster properties and the number of duplicates not added. It also seems pruning should add two more conditions for some deadman monsters sneaking in # Prune...
if (
# ...monsters that do not have any hitpoints
monster["skills"]["hp"] == 0
# ...monsters that don't have an ID
or monster["id"] is None
# ...monsters that are historical
or "(historical)" in str.lower(monster["name"])
# ...monsters from the PvM arena
or "(pvm arena)" in str.lower(monster["name"])
# ...monsters from DMM Apocalypse
or "(deadman: apocalypse)" in str.lower(monster["name"])
or "(deadman)" in str.lower(monster["name"])
or "(deadman mode)" in str.lower(monster["name"])
): |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
One of the annoyances I have is the large amount of cosmetic variants that clutter the monster search. Typing in "Zombie Pirate" gives six cosmetic braindeath island monsters and 26 cosmetic harmony island monsters.
I wrote a function to filter out mobs with the same name, different version, and same stats. I'm marking this as a draft to get some feedback. There are some things removed like four different Abyssal Sire variants which all have the same statistics. I wanted to get some feedback on how this should be implemented.