Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't use String #142

Closed
phadej opened this issue Sep 3, 2024 · 1 comment
Closed

Don't use String #142

phadej opened this issue Sep 3, 2024 · 1 comment
Assignees

Comments

@phadej
Copy link
Collaborator

phadej commented Sep 3, 2024

We use String for names, not great.

I think ShortText is better. I don't think there can be identifiers which are not valid text. But we can also use ShortByteString to be sure.

That said, I think having a newtype Name would help separate names from everything else. (In particular Names is something we will need to mangle as lexically C and Haskell are different)

@edsko edsko added this to the 1: `Storable` instances milestone Sep 4, 2024
@edsko edsko self-assigned this Sep 21, 2024
@edsko
Copy link
Collaborator

edsko commented Sep 21, 2024

Putting some basic infra in place for this, but will defer name mangling to a separate ticket #189.

edsko added a commit that referenced this issue Sep 21, 2024
edsko added a commit that referenced this issue Sep 21, 2024
@edsko edsko closed this as completed in 43c5e12 Sep 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants