-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Concepts filters & toggle clean-up #11506
Open
kenoir
wants to merge
2
commits into
main
Choose a base branch
from
rk/concepts-cleanup-filters-n-toggle
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Size Change: -23 B (0%) Total Size: 1.02 MB
ℹ️ View Unchanged
|
16 tasks
gestchild
approved these changes
Jan 20, 2025
@kenoir tests have failed, might be a wobble though. but it hasn't merged because of it fyi |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note
We should merge this on or after 2024-01-20
What does this change?
Follows: #11505
This change implements a couple of small clean-ups to the concepts work.
How to test
How can we measure success?
Happier developers because unused or incorrect code isn't hanging around to confuse people.
Have we considered potential risks?
This should not change any user facing content. We are keeping the old pipeline around until Monday, 2024-01-20 in case we need to revert, so a good idea to wait until that's deleted to ensure we don't need to roll this back.