Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using go-libsass on a Mac on OSX 14.1.1, it would fail with "File to import not found or unreadable: " errors.
The issue is in libsass in the
read_file
function infile.cpp
. On non-_WIN32 OS's it usesstd::ifstream
to read the file. On OSX it always fails withstrerror(errno)
saying "Failure: too many open files".On my system,
ulimit
andulimit -n
return the default "unlimited" / 256. So I tried raising it in/Library/LaunchDaemons/limit.maxfiles.plist
but it still didn't help.I tried reverting the most recent change in
file.cpp
which usedfopen
instead ofstd::ifstream
. It still failed.So, I tried using the Darwin
open
/read
and it works!