Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix gpu-onnx infer #2562

Merged
merged 10 commits into from
Jul 9, 2024
Merged

fix gpu-onnx infer #2562

merged 10 commits into from
Jul 9, 2024

Conversation

LRY1994
Copy link
Contributor

@LRY1994 LRY1994 commented Jul 2, 2024

fix eos sos to depending on dict or config

@xingchensong
Copy link
Member

请根据这里的提示 https://github.com/wenet-e2e/wenet/actions/runs/9762251705/job/26970942324#step:5:1 修复lint错误

@xingchensong xingchensong requested a review from Slyne July 4, 2024 04:20
@xingchensong
Copy link
Member

xingchensong commented Jul 4, 2024

UnitTest 错误看起来和本PR无关,请 @Slyne 大佬审核下,没啥问题可以直接合并 :)

Copy link
Collaborator

@Slyne Slyne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @LRY1994, thanks for the PR to make it flexible to read blankid, eos, sos id from config file.
Codes look good to me.
Please refer to the comments about formatting.

Appreciated!

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, cur_mask_len 这个改动是必须的吗?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

源代码里面有hist_enc为None的情况,len(None)会报错,测试的时候确实也有出现hist_enc为None的情况。

if hist_enc is None:
  cur_enc = cur_encoder_out[idx]
.....
cur_mask_len = int(len(hist_enc) + seq_lens[idx])

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Didn't realize we changed the initial history cache. FYI, @yuekaizhang Didn't we find this issue before?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you remove the blank lines? Or just use one blank line instead of two lines? Thanks!

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

已删除

Copy link
Collaborator

@Slyne Slyne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@Slyne Slyne merged commit fae6a8c into wenet-e2e:main Jul 9, 2024
6 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants