-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix gpu-onnx infer #2562
fix gpu-onnx infer #2562
Conversation
UnitTest 错误看起来和本PR无关,请 @Slyne 大佬审核下,没啥问题可以直接合并 :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @LRY1994, thanks for the PR to make it flexible to read blankid, eos, sos id from config file.
Codes look good to me.
Please refer to the comments about formatting.
Appreciated!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi, cur_mask_len
这个改动是必须的吗?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
源代码里面有hist_enc为None的情况,len(None)会报错,测试的时候确实也有出现hist_enc为None的情况。
if hist_enc is None:
cur_enc = cur_encoder_out[idx]
.....
cur_mask_len = int(len(hist_enc) + seq_lens[idx])
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! Didn't realize we changed the initial history cache. FYI, @yuekaizhang Didn't we find this issue before?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you remove the blank lines? Or just use one blank line instead of two lines? Thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
已删除
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
fix eos sos to depending on dict or config