Skip to content
This repository has been archived by the owner on May 18, 2022. It is now read-only.

verbose logging appears out of order for custom theme install #136

Open
Toddses opened this issue Jan 31, 2015 · 0 comments
Open

verbose logging appears out of order for custom theme install #136

Toddses opened this issue Jan 31, 2015 · 0 comments
Labels

Comments

@Toddses
Copy link
Collaborator

Toddses commented Jan 31, 2015

This is what you see (v2.0.0):

>> Starting theme setup
Setting Up Theme
Installing Node Packages (be patient)
>> Theme setup complete

Then you wait... and, finally

Running Grunt Setup
Theme setup!

This would make more sense for the completion note to come in after everything else is done. This has to do with sending this.async() to the wordpress.js util function, it doesn't stop execution of the task, only execution of the following tasks.

One possible fix is to run the task async and send the wordpress.js util functions a callback. We can control the flow of the wordpress.js util functions, while preventing the execution of the remaining code in the task. All the console messages will be in the right order. Funtimes.

@Toddses Toddses added the bug label Feb 6, 2015
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

1 participant