Skip to content
This repository has been archived by the owner on May 18, 2022. It is now read-only.

Use Git? set to false in .yeopress, but prompt still set to Yes #172

Open
nocean opened this issue Sep 25, 2015 · 5 comments
Open

Use Git? set to false in .yeopress, but prompt still set to Yes #172

nocean opened this issue Sep 25, 2015 · 5 comments

Comments

@nocean
Copy link
Contributor

nocean commented Sep 25, 2015

I'm setting "git": false in a custom .yeopress file, but the default for the "Use Git?" prompt remains "Yes" (Y/n).

Glancing through app/prompts.js, it does appear to be set to a default of "no", which matches the readme documentation talking about overriding this. However, even without a custom .yeopress file, when running yo wordpress it defaults to yes.

BTW: I love this project. Thanks so much for it.

@wesleytodd
Copy link
Owner

So I am not sure, but it does look like the 'N' default value would evaluate to true. Do you think you can try swapping that for false in here and see if you get the desired effect?

If so I would love a PR or I can make the change and publish really quick.

@wesleytodd
Copy link
Owner

FWIW, this used to work, but reading the inquirer documentation it says a boolean value. So maybe it changed??? I guess that is what software does...

nocean added a commit to nocean/YeoPress that referenced this issue Sep 27, 2015
Changes from 'N' string to boolean "false", as reported [here](wesleytodd#172)
@nocean
Copy link
Contributor Author

nocean commented Sep 27, 2015

Just tested, and changing to false works as expected -- also tested overriding with a .yeopress file, and it also works as expected. Just submitted the PR. Let me know if I did anything wrong, first time I've ever submitted a change on GitHub.

@wesleytodd
Copy link
Owner

Hey, so it looks like you pushed your work but didnt open the PR. On your repo page you will have a button to open a PR. Make sure you submit it against the develop branch as it talks about in the contributor docs: https://github.com/wesleytodd/YeoPress/blob/master/CONTRIBUTING.md

I looked at the change and it looks good! Thanks for finding and fixing this!

@nocean
Copy link
Contributor Author

nocean commented Sep 28, 2015

Oops. Just did. (fingers crossed)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants