Add a WASI file system that grants access to IPFS #11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I've laid out the skeleton of every trait we will have to implement to be able to provide the file system. For the time being I am hopeful we'll be able to "forward" most of these calls to an underlying attribute, but I'm also cautiously aware that it will most likely be considerably more complicated than that... |
lthibault
reviewed
Oct 15, 2024
|
|
||
| use net::ipfs::Client; | ||
|
|
||
| pub struct IpfsFs { |
There was a problem hiding this comment.
Can we add a doc string to this type too?
| self.consume_stream(stream).await | ||
| } | ||
|
|
||
| pub fn delete_me(&self) { |
There was a problem hiding this comment.
What's delete_me? Is that some kind of destructor method?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.