fix: italic google fonts (#233)

* fix: italic fonts from google * chore: changesets * nit: remove patch * nit: lint
wevm · Apr 10, 2024 · 8a29c4d · 8a29c4d
1 parent 50b2cc7
commit 8a29c4d
Show file tree

Hide file tree

Showing 6 changed files with 23 additions and 61 deletions.
diff --git a/.changeset/spotty-spoons-tickle.md b/.changeset/spotty-spoons-tickle.md
@@ -0,0 +1,5 @@
+---
+"frog": patch
+---
+
+Fixed incorrect resolution of Google Font with italic style.
diff --git a/playground/src/index.tsx b/playground/src/index.tsx
@@ -34,10 +34,10 @@ export const app = new Frog({
           alignHorizontal="center"
           alignVertical="center"
         >
-          <Heading>
+          <Heading style="italic">
             {status === 'response'
               ? `Nice choice.${fruit ? ` ${fruit.toUpperCase()}!!` : ''}`
-              : 'Welcome :)'}
+              : 'Welcome 🐸'}
           </Heading>
         </Box>
       ),

diff --git a/playground/src/ui.ts b/playground/src/ui.ts
@@ -21,16 +21,19 @@ export const {
       {
         name: 'Open Sans',
         source: 'google',
+        style: 'italic',
         weight: 400,
       },
       {
         name: 'Open Sans',
         source: 'google',
+        style: 'italic',
         weight: 600,
       },
       {
         name: 'Open Sans',
         source: 'google',
+        style: 'italic',
         weight: 700,
       },
     ],

diff --git a/pnpm-lock.yaml b/pnpm-lock.yaml
diff --git a/src/package.json b/src/package.json
@@ -94,7 +94,7 @@
     "dom-parser": "^1.1.5",
     "fast-glob": "3.3.2",
     "fs-extra": "^11.2.0",
-    "hono-og": "0.0.26",
+    "hono-og": "0.0.27",
     "jose": "^5.2.2",
     "lz-string": "^1.5.0",
     "path-browserify": "^1.0.1",

diff --git a/src/utils/parseFonts.ts b/src/utils/parseFonts.ts
@@ -11,6 +11,7 @@ export async function parseFonts(fonts: Font[] | undefined) {
           data: await loadGoogleFont({
             family: font.name,
             weight: font.weight,
+            style: font.style,
           }),
         }
       return font