Replies: 9 comments
-
Yeah, looks like Frog uses Line 695 in 3fc8b5c |
Beta Was this translation helpful? Give feedback.
-
Adding relevant updates here as well:
Update: we merged frames and got them to work here jk-labs-inc/jokerace#1535, now just have the edge case documented in this comment below - #239 (comment)! |
Beta Was this translation helpful? Give feedback.
-
@seanmc9, correct, and you can set
@seanmc9, we can ask for this to be changed if we can word the motivation behind it properly!
@seanmc9, I think there was a little misinterpretation by @horsefacts, the issue is different, The main issue is that The solution sounds trivial – to add this initial data to path parameters, but as long as parameters are big in size, the end url exceeds 256 bytes limit. There are two possible solutions with different amount of effort from different teams I see to resolve it:
What I mean by the latter, is that pasting addresses as path parameters seems trivial but some compressing serialization has to be applied to shorten the size of the data. Assuming that the frame URL is generated somewhere on your FE when a user clicks on "share on wc" button, you'd have to put those parameters somewhere in the db (let's say redis), and put a single redis key as the path parameter. Then in the frame, you deserialize it by retrieving the value from redis. that's not cool, but it's the only way I see such to be implemented. |
Beta Was this translation helpful? Give feedback.
-
@dalechyn Wow, thank you so much for this through response! This all makes sense and yeah, option 2 would be quite a bit of implementation vs if we could just even get the |
Beta Was this translation helpful? Give feedback.
-
Also re the initial frame, @nakedfool figured out a workaround in the PR we merged for frames jk-labs-inc/jokerace#1535 where the first frame is effectively a loading one, and then we are able to get the dynamic We still have an edge case where sometimes for voting frames specifically, if the submission that is being voted on is too long, the url goes just above the limit and so that specific frame doesn't work, which is why we're still looking to get the limit raised. It would also allow us to not have to use the loading workaround with the initial frame and just have the initial frame contain the main logic too! re asking for it to be bumped, this was the description and examples we gave: This is an example of our voting frame where the post url is too long and so the frame doesn’t render correctly https://warpcast.com/seanmc/0xe78b671b And this is an example of our voting frame that is working correctly https://warpcast.com/seanmc/0xcf59e8e0 It’s unfortunately a problem that is only happening for specific submissions that are sufficiently long and on chains with names that are longer, thereby pushing the post url just over the limit. But 512 bytes would be more than enough for this to solidly not be a problem. |
Beta Was this translation helpful? Give feedback.
-
What if you serialized the id here as hexadecimal number? Should save up some bytes |
Beta Was this translation helpful? Give feedback.
-
Yeah, we thought about that but it would either mean we couldn't use the direct link to the contest or proposal for the frame or it would be a pretty major refactor in our front and backend to use hex instead of integer for So if we can get a comprehensive fix for the current issue, still make it as easy as possible for people to share the frame, and avoid a major refactor, that's what we're most trying to prioritize with pushing for the limit to be raised. |
Beta Was this translation helpful? Give feedback.
-
Converting to discussion. |
Beta Was this translation helpful? Give feedback.
-
Post URL length was bumped to 1024: farcasterxyz/hub-monorepo#2174 |
Beta Was this translation helpful? Give feedback.
-
Describe the bug
Hi,
I'm currently experiencing an issue where i'm trying to deploy a frame with a
post_url
that has a one or more dynamic parameters in the URL. Current issue is, thatpost_url
is expecting it to be less than 256 bytesI was talking on discord today with one of the frog mods and they even casted on warpcast for asking a possible solution ( see here ), which seems to be to use state that allows up to 4096 bytes.
The last point here is, whether or not frog supports states. That is, how can we utilise frog to use dynamic parameters if the current limit for
post_url
is 256 bytes, and is there a plan of implementing this in the near future?Link to Minimal Reproducible Example
No response
Steps To Reproduce
No response
Frog Version
0.8.1
TypeScript Version
5.0.4
Check existing issues
Anything else?
No response
Beta Was this translation helpful? Give feedback.
All reactions