wip: redirect #4
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tmm
commented
Feb 13, 2024
| <Button action="post_redirect" value="apples"> | ||
| <Button | ||
| action="post_redirect" | ||
| value="https://github.com/wevm/viem/blob/main/src/clients/createClient.ts" |
There was a problem hiding this comment.
Setting value to URL to redirect to. Reason this is in .frame is so you can use dynamic content from context.
tmm
force-pushed
the
tmm/feat-redirect
branch
2 times, most recently
from
8c1df45
to
a9be757
Compare
tmm
commented
Feb 13, 2024
| @@ -23,6 +23,7 @@ export function ButtonRoot({ | |||
| <meta | |||
| property={`fc:frame:button:${index}`} | |||
| content={children} | |||
| data-type={action === 'post_redirect' ? 'redirect' : undefined} | |||
There was a problem hiding this comment.
Wonder if it makes sense to add a Button.Redirect component instead of overloading Button?
jxom
force-pushed
the
tmm/feat-redirect
branch
from
a9be757
to
89ea8c1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fc:frame:button:$idx:target