Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: provide base path generic param #455

Merged
merged 2 commits into from
Jul 31, 2024
Merged

fix: provide base path generic param #455

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b9d0dd9
fix: provide `basePath` to `initialState` callback
dalechyn Jul 30, 2024
b8467d1
chore: changesets
dalechyn Jul 30, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/long-kiwis-matter.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"frog": patch
---

Fixed an issue where `basePath` was not provided to the callback used in `initialState` parameter.
36 changes: 22 additions & 14 deletions src/frog-base.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -147,7 +147,7 @@ export type FrogConstructorParameters<
* ```
*/
initialState?:
| ((c: Context<env>) => _state | Promise<_state>)
| ((c: Context<env, basePath>) => _state | Promise<_state>)
| _state
| undefined
/**
Expand Down Expand Up @@ -273,18 +273,21 @@ export class FrogBase<
> {
// Note: not using native `private` fields to avoid tslib being injected
// into bundled code.
_initialState:
| ((c: Context<env>) => _state | Promise<_state>)
| _state
| undefined = undefined
_initialState: FrogConstructorParameters<
env,
basePath,
_state
>['initialState'] = undefined
/** Path for assets. */
assetsPath: string
/** Base path of the server instance. */
basePath: string
/** URL to redirect to when the user is coming to the page via a browser. */
browserLocation: string | undefined
dev: FrogConstructorParameters['dev'] | undefined
headers: FrogConstructorParameters['headers'] | undefined
dev: FrogConstructorParameters<env, basePath, _state>['dev'] | undefined
headers:
| FrogConstructorParameters<env, basePath, _state>['headers']
| undefined
/** Hono instance. */
hono: Hono<env, schema, basePath>
/** Farcaster Hub API URL. */
Expand All @@ -301,18 +304,23 @@ export class FrogBase<
get: Hono<env, schema, basePath>['get']
post: Hono<env, schema, basePath>['post']
/** Key used to sign secret data. */
secret: FrogConstructorParameters['secret'] | undefined
secret: FrogConstructorParameters<env, basePath, _state>['secret'] | undefined
/** Title of the frame to be set at `og:title` **/
title: FrogConstructorParameters['title']
title: FrogConstructorParameters<env, basePath, _state>['title']
/** FrogUI configuration. */
ui: { vars: Vars | undefined } | undefined
/** Whether or not frames should be verified. */
verify: FrogConstructorParameters['verify'] =
verify: FrogConstructorParameters<env, basePath, _state>['verify'] =
process.env.NODE_ENV === 'production'
verifyOrigin: FrogConstructorParameters['verifyOrigin'] =
process.env.NODE_ENV === 'production'

metaTags: FrogConstructorParameters['unstable_metaTags'] | undefined
verifyOrigin: FrogConstructorParameters<
env,
basePath,
_state
>['verifyOrigin'] = process.env.NODE_ENV === 'production'

metaTags:
| FrogConstructorParameters<env, basePath, _state>['unstable_metaTags']
| undefined

_dev: string | undefined
version = version
Expand Down
Loading