Fix CSS according to the issue on WV-135 (Second attempt) #3770
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… in PrivacyBody.jsx
…and Android Resolves https://wevoteusa.atlassian.net/jira/software/projects/WV/issues/WV-157 The App loses main menu for signed-in users Resolves https://wevoteusa.atlassian.net/jira/software/projects/WV/issues/WV-155 Re-enabled "Help them win" on Candidate pages for Cordova. When I work on css issues in Cordova, I have to work backwards from DOM element, so it is important that StyledComponents have a name that resolves to a single object in the code --- SignInOptionsPanelWrapper was uncopied where possible, renamed where not. Resolves https://wevoteusa.atlassian.net/jira/software/projects/WV/issues/WV-152 Title of "Sign In with Mobile Number" field cut off Resolves https://wevoteusa.atlassian.net/jira/software/projects/WV/issues/WV-156 User can't close the "Complete your support" page on some iOS Devices
…and Android Resolves https://wevoteusa.atlassian.net/jira/software/projects/WV/issues/WV-157 The App loses main menu for signed-in users Resolves https://wevoteusa.atlassian.net/jira/software/projects/WV/issues/WV-155 Re-enabled "Help them win" on Candidate pages for Cordova. When I work on css issues in Cordova, I have to work backwards from DOM element, so it is important that StyledComponents have a name that resolves to a single object in the code --- SignInOptionsPanelWrapper was uncopied where possible, renamed where not. Resolves https://wevoteusa.atlassian.net/jira/software/projects/WV/issues/WV-152 Title of "Sign In with Mobile Number" field cut off Resolves https://wevoteusa.atlassian.net/jira/software/projects/WV/issues/WV-156 User can't close the "Complete your support" page on some iOS Devices
…to prevent string methods from trying to execute with a null value
…tioning /more/privacy links to /privacy.
…er requests data deletion
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What github.com/wevote/WebApp/issues does this fix?
Fix CSS according to the issue on WV-135 (Second attempt)
Changes included this pull request?