Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix CSS according to the issue on WV-135 (Second attempt) #3770

Closed
wants to merge 26 commits into from
Closed

Fix CSS according to the issue on WV-135 (Second attempt) #3770

wants to merge 26 commits into from

Commits on Oct 22, 2023

  1. fix link

    Ivan Kordonets committed Oct 22, 2023
    Configuration menu
    Copy the full SHA
    cc4e960 View commit details
    Browse the repository at this point in the history

  2. Resolved merge conflict in package-lock.json

    Ivan Kordonets committed Oct 22, 2023
    Configuration menu
    Copy the full SHA
    dca530e View commit details
    Browse the repository at this point in the history

Commits on Oct 23, 2023

  1. add missing packeges

    Ivan Kordonets committed Oct 23, 2023
    Configuration menu
    Copy the full SHA
    c8fe298 View commit details
    Browse the repository at this point in the history

  2. stash

    Ivan Kordonets committed Oct 23, 2023
    Configuration menu
    Copy the full SHA
    afaed78 View commit details
    Browse the repository at this point in the history

Commits on Nov 3, 2023

  1. Resolved merge conflicts.

    Ivan Kordonets committed Nov 3, 2023
    Configuration menu
    Copy the full SHA
    1685041 View commit details
    Browse the repository at this point in the history

  2. stash

    Ivan Kordonets committed Nov 3, 2023
    Configuration menu
    Copy the full SHA
    2eef89e View commit details
    Browse the repository at this point in the history

  3. merge

    Ivan Kordonets committed Nov 3, 2023
    Configuration menu
    Copy the full SHA
    66c32f9 View commit details
    Browse the repository at this point in the history

  4. replace link to request account deletion with DeleteYourAccountButton… 

    … in PrivacyBody.jsx
    @andykb9b13
    andykb9b13 authored and Ivan Kordonets committed Nov 3, 2023
    Configuration menu
    Copy the full SHA
    4b12e3c View commit details
    Browse the repository at this point in the history

  5. rolled back package.json file and package-lock.json file to commit 9c… 

    …b207a
    @andykb9b13
    andykb9b13 authored and Ivan Kordonets committed Nov 3, 2023
    Configuration menu
    Copy the full SHA
    c106fc3 View commit details
    Browse the repository at this point in the history

  6. Resolves 4 jira issues, plus more Cordova offset adjustments for iOS … 

    …and Android

Resolves https://wevoteusa.atlassian.net/jira/software/projects/WV/issues/WV-157  The App loses main menu for signed-in users
Resolves https://wevoteusa.atlassian.net/jira/software/projects/WV/issues/WV-155  Re-enabled "Help them win" on Candidate pages for Cordova.
When I work on css issues in Cordova, I have to work backwards from DOM element, so it is important that StyledComponents have a name that resolves to a single object in the code --- SignInOptionsPanelWrapper was uncopied where possible, renamed where not.
Resolves https://wevoteusa.atlassian.net/jira/software/projects/WV/issues/WV-152   Title of "Sign In with Mobile Number" field cut off
Resolves https://wevoteusa.atlassian.net/jira/software/projects/WV/issues/WV-156   User can't close the "Complete your support" page on some iOS Devices
    @SailingSteve
    SailingSteve authored and Ivan Kordonets committed Nov 3, 2023
    Configuration menu
    Copy the full SHA
    242a80e View commit details
    Browse the repository at this point in the history

  7. Resolves 4 jira issues, plus more Cordova offset adjustments for iOS … 

    …and Android

Resolves https://wevoteusa.atlassian.net/jira/software/projects/WV/issues/WV-157  The App loses main menu for signed-in users
Resolves https://wevoteusa.atlassian.net/jira/software/projects/WV/issues/WV-155  Re-enabled "Help them win" on Candidate pages for Cordova.
When I work on css issues in Cordova, I have to work backwards from DOM element, so it is important that StyledComponents have a name that resolves to a single object in the code --- SignInOptionsPanelWrapper was uncopied where possible, renamed where not.
Resolves https://wevoteusa.atlassian.net/jira/software/projects/WV/issues/WV-152   Title of "Sign In with Mobile Number" field cut off
Resolves https://wevoteusa.atlassian.net/jira/software/projects/WV/issues/WV-156   User can't close the "Complete your support" page on some iOS Devices
    @SailingSteve
    SailingSteve authored and Ivan Kordonets committed Nov 3, 2023
    Configuration menu
    Copy the full SHA
    54d37a9 View commit details
    Browse the repository at this point in the history

  8. add optional chaining operator to organization and guide information … 

    …to prevent string methods from trying to execute with a null value
    @andykb9b13
    andykb9b13 authored and Ivan Kordonets committed Nov 3, 2023
    Configuration menu
    Copy the full SHA
    6a73e93 View commit details
    Browse the repository at this point in the history

  9. Updated disclosure text as required by Google Play store. Also transi… 

    …tioning /more/privacy links to /privacy.
    @DaleMcGrew
    DaleMcGrew authored and Ivan Kordonets committed Nov 3, 2023
    Configuration menu
    Copy the full SHA
    386f4a8 View commit details
    Browse the repository at this point in the history

  10. Code refactoring after WV-143 bug report was fixed

    Stas L authored and Ivan Kordonets committed Nov 3, 2023
    Configuration menu
    Copy the full SHA
    214bbf6 View commit details
    Browse the repository at this point in the history

  11. Code refactoring after WV-140 bug report was fixed

    Stas L authored and Ivan Kordonets committed Nov 3, 2023
    Configuration menu
    Copy the full SHA
    1e9466a View commit details
    Browse the repository at this point in the history

  12. Fixed a bug that prevents client-side data from clearing after the us… 

    …er requests data deletion
    @nyette
    nyette authored and Ivan Kordonets committed Nov 3, 2023
    Configuration menu
    Copy the full SHA
    6efa176 View commit details
    Browse the repository at this point in the history

  13. fix css for candidate

    Ivan Kordonets committed Nov 3, 2023
    Configuration menu
    Copy the full SHA
    6ea1abd View commit details
    Browse the repository at this point in the history

  14. commit changes

    Ivan Kordonets committed Nov 3, 2023
    Configuration menu
    Copy the full SHA
    cc802cd View commit details
    Browse the repository at this point in the history

  15. Issue #wv-135

    Ivan Kordonets committed Nov 3, 2023
    Configuration menu
    Copy the full SHA
    b42c7e8 View commit details
    Browse the repository at this point in the history

Commits on Nov 4, 2023

  1. fix link

    Ivan Kordonets committed Nov 4, 2023
    Configuration menu
    Copy the full SHA
    4a9f154 View commit details
    Browse the repository at this point in the history

  2. fix

    Ivan Kordonets committed Nov 4, 2023
    Configuration menu
    Copy the full SHA
    12632f5 View commit details
    Browse the repository at this point in the history

  3. merge

    Ivan Kordonets committed Nov 4, 2023
    Configuration menu
    Copy the full SHA
    50b5f19 View commit details
    Browse the repository at this point in the history

  4. merge

    Ivan Kordonets committed Nov 4, 2023
    Configuration menu
    Copy the full SHA
    adeb010 View commit details
    Browse the repository at this point in the history

Commits on Nov 7, 2023

  1. merge conflict

    Ivan Kordonets committed Nov 7, 2023
    Configuration menu
    Copy the full SHA
    be21183 View commit details
    Browse the repository at this point in the history

  2. merge conflicts on package-lock.json

    Ivan Kordonets committed Nov 7, 2023
    Configuration menu
    Copy the full SHA
    a735c7b View commit details
    Browse the repository at this point in the history

  3. merge with develop

    Ivan Kordonets committed Nov 7, 2023
    Configuration menu
    Copy the full SHA
    9471d5e View commit details
    Browse the repository at this point in the history