From d853b637deaeb90b781b9c77132ea9beffba4d7b Mon Sep 17 00:00:00 2001 From: Joey Arhar Date: Wed, 31 Jan 2024 07:59:09 -0800 Subject: [PATCH 1/4] Don't close ancestor popovers when fullscreening Without this patch, the fullscreening an element inside an open popover will make the fullscreen element display:none. Issue: https://github.com/whatwg/html/issues/9998 Corresponding HTML PR: https://github.com/whatwg/html/pull/10116 --- fullscreen.bs | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/fullscreen.bs b/fullscreen.bs index a772f2c..6e9f78f 100644 --- a/fullscreen.bs +++ b/fullscreen.bs @@ -67,7 +67,10 @@ is an ordered set of (string, element) tuples. It is

To fullscreen an element:

    -

  1. Run hide all popovers given element's node document. +

  2. Let hideUntil be the result of running topmost popover ancestor given + element, null, and false. + +

  3. Run hide all popovers until given hideUntil, false, and true.

  4. Set element's fullscreen flag. From 83a90abb607ff0ebad2f2a18b653b3b5a1ab5966 Mon Sep 17 00:00:00 2001 From: Joey Arhar Date: Tue, 6 Feb 2024 11:55:01 -0800 Subject: [PATCH 2/4] fix null hideUntil --- fullscreen.bs | 3 +++ 1 file changed, 3 insertions(+) diff --git a/fullscreen.bs b/fullscreen.bs index 6e9f78f..ada1cd4 100644 --- a/fullscreen.bs +++ b/fullscreen.bs @@ -70,6 +70,9 @@ is an ordered set of (string, element) tuples. It is

  5. Let hideUntil be the result of running topmost popover ancestor given element, null, and false. +

  6. If hideUntil is null, then set hideUntil to element's + node document.

    7. +

  7. Run hide all popovers until given hideUntil, false, and true.

  8. Set element's fullscreen flag. From afb3cb5290006dda31402619c3b4ba34ed1c81d7 Mon Sep 17 00:00:00 2001 From: Joey Arhar Date: Fri, 3 May 2024 15:12:09 -0700 Subject: [PATCH 3/4] Re-run checks please From 4bd1b116bf5cf1cfa1d42f705bee3e690ae5c6ee Mon Sep 17 00:00:00 2001 From: Domenic Denicola Date: Tue, 7 May 2024 11:21:52 +0900 Subject: [PATCH 4/4] Remove end tags for consistency --- fullscreen.bs | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/fullscreen.bs b/fullscreen.bs index ada1cd4..ce9ed9f 100644 --- a/fullscreen.bs +++ b/fullscreen.bs @@ -71,7 +71,7 @@ is an ordered set of (string, element) tuples. It is element, null, and false.

  9. If hideUntil is null, then set hideUntil to element's - node document.

    10. + node document.

  10. Run hide all popovers until given hideUntil, false, and true.