Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add dialog light dismiss behavior #10737

Open
wants to merge 10 commits into
base: main
Choose a base branch
from
Open

Add dialog light dismiss behavior #10737

wants to merge 10 commits into from
+284 −7

Commits on Oct 31, 2024

  1. Add closedby attribute to <dialog> 

    First commit is pulled from whatwg#10157
    @mfreed7
    mfreed7 committed Oct 31, 2024
    Configuration menu
    Copy the full SHA
    ad9d00f View commit details
    Browse the repository at this point in the history

  2. Small tweaks

    @mfreed7
    mfreed7 committed Oct 31, 2024
    Configuration menu
    Copy the full SHA
    b058a2c View commit details
    Browse the repository at this point in the history

  3. Add requestClose()

    @mfreed7
    mfreed7 committed Oct 31, 2024
    Configuration menu
    Copy the full SHA
    34dd8cf View commit details
    Browse the repository at this point in the history

  4. Fix tag nesting

    @mfreed7
    mfreed7 committed Oct 31, 2024
    Configuration menu
    Copy the full SHA
    a1f962d View commit details
    Browse the repository at this point in the history

Commits on Nov 1, 2024

  1. Move note out of OL

    @mfreed7
    mfreed7 committed Nov 1, 2024
    Configuration menu
    Copy the full SHA
    ef73d72 View commit details
    Browse the repository at this point in the history

Commits on Nov 8, 2024

  1. Address comments

    @mfreed7
    mfreed7 committed Nov 8, 2024
    Configuration menu
    Copy the full SHA
    cc9598c View commit details
    Browse the repository at this point in the history

  2. Check for open attribute

    @mfreed7
    mfreed7 committed Nov 8, 2024
    Configuration menu
    Copy the full SHA
    c458c23 View commit details
    Browse the repository at this point in the history

Commits on Nov 13, 2024

  1. Adjust algorithm to match impl and tests

    @mfreed7
    mfreed7 committed Nov 13, 2024
    Configuration menu
    Copy the full SHA
    c18d65f View commit details
    Browse the repository at this point in the history

  2. Address comments

    @mfreed7
    mfreed7 committed Nov 13, 2024
    Configuration menu
    Copy the full SHA
    fc56ba9 View commit details
    Browse the repository at this point in the history

  3. Update attribute index

    @mfreed7
    mfreed7 committed Nov 13, 2024
    Configuration menu
    Copy the full SHA
    a115f26 View commit details
    Browse the repository at this point in the history