Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use matches about:blank in more cases #9558

Merged
merged 1 commit into from
Jul 26, 2023
Merged

Use matches about:blank in more cases #9558

merged 1 commit into from
Jul 26, 2023

Conversation

domfarolino
Copy link
Member

@domfarolino domfarolino commented Jul 25, 2023 •
edited by pr-preview bot
Loading

This PR handles the "about:blank" side of #9488 by using "matches about:blank" in the two places that issue identifies.

(See WHATWG Working Mode: Changes for more details.)

/browsing-the-web.html ( diff )
/urls-and-fetching.html ( diff )

@domfarolino domfarolino requested a review from domenic July 25, 2023 18:45
@domfarolino domfarolino marked this pull request as ready for review July 25, 2023 18:46
@chromium-wpt-export-bot chromium-wpt-export-bot mentioned this pull request Jul 25, 2023
Merged
chromium-wpt-export-bot pushed a commit to web-platform-tests/wpt that referenced this pull request Jul 25, 2023
@domfarolino @chromium-wpt-export-bot
Matches about:blank WPTs
e26a271 
This CL adds WPTs for whatwg/html#9558, which
uses the "matches about:blank" definition [1] in two places where
"about:blank" URL equivalence checks currently are.

[1]: https://html.spec.whatwg.org/#matches-about:blank

R=domenic@chromium.org

Bug: N/A
Change-Id: I840f445d3c7224f70a09e481f3e5727422ca2d83
@domfarolino domfarolino mentioned this pull request Jul 25, 2023
Closed
@domenic domenic merged commit b729c06 into main Jul 26, 2023
1 check passed
@domenic domenic deleted the domfarolino/use-matches branch July 26, 2023 01:48
chromium-wpt-export-bot pushed a commit to web-platform-tests/wpt that referenced this pull request Jul 26, 2023
@domfarolino @chromium-wpt-export-bot
Matches about:blank WPTs
7fc6872 
This CL adds WPTs for whatwg/html#9558, which
uses the "matches about:blank" definition [1] in two places where
"about:blank" URL equivalence checks currently are.

[1]: https://html.spec.whatwg.org/#matches-about:blank

R=domenic@chromium.org

Bug: N/A
Change-Id: I840f445d3c7224f70a09e481f3e5727422ca2d83
aarongable pushed a commit to chromium/chromium that referenced this pull request Jul 26, 2023
@domfarolino
Matches about:blank WPTs
81e6bb8 
This CL adds WPTs for whatwg/html#9558, which
uses the "matches about:blank" definition [1] in two places where
"about:blank" URL equivalence checks currently are.

[1]: https://html.spec.whatwg.org/#matches-about:blank

R=domenic@chromium.org

Bug: N/A
Change-Id: I840f445d3c7224f70a09e481f3e5727422ca2d83
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4718105
Reviewed-by: Domenic Denicola <domenic@chromium.org>
Commit-Queue: Dominic Farolino <dom@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1175589}
chromium-wpt-export-bot pushed a commit to web-platform-tests/wpt that referenced this pull request Jul 26, 2023
@domfarolino @chromium-wpt-export-bot
Matches about:blank WPTs
6621f10 
This CL adds WPTs for whatwg/html#9558, which
uses the "matches about:blank" definition [1] in two places where
"about:blank" URL equivalence checks currently are.

[1]: https://html.spec.whatwg.org/#matches-about:blank

R=domenic@chromium.org

Bug: N/A
Change-Id: I840f445d3c7224f70a09e481f3e5727422ca2d83
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4718105
Reviewed-by: Domenic Denicola <domenic@chromium.org>
Commit-Queue: Dominic Farolino <dom@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1175589}
chromium-wpt-export-bot pushed a commit to web-platform-tests/wpt that referenced this pull request Jul 26, 2023
@domfarolino @chromium-wpt-export-bot
Matches about:blank WPTs
9a32587 
This CL adds WPTs for whatwg/html#9558, which
uses the "matches about:blank" definition [1] in two places where
"about:blank" URL equivalence checks currently are.

[1]: https://html.spec.whatwg.org/#matches-about:blank

R=domenic@chromium.org

Bug: N/A
Change-Id: I840f445d3c7224f70a09e481f3e5727422ca2d83
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4718105
Reviewed-by: Domenic Denicola <domenic@chromium.org>
Commit-Queue: Dominic Farolino <dom@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1175589}
moz-v2v-gh pushed a commit to mozilla/gecko-dev that referenced this pull request Aug 2, 2023
@domfarolino @moz-wptsync-bot
Bug 1845389 [wpt PR 41176] - Matches about:blank WPTs, a=testonly
1ad905d 
Automatic update from web-platform-tests
Matches about:blank WPTs

This CL adds WPTs for whatwg/html#9558, which
uses the "matches about:blank" definition [1] in two places where
"about:blank" URL equivalence checks currently are.

[1]: https://html.spec.whatwg.org/#matches-about:blank

R=domenic@chromium.org

Bug: N/A
Change-Id: I840f445d3c7224f70a09e481f3e5727422ca2d83
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4718105
Reviewed-by: Domenic Denicola <domenic@chromium.org>
Commit-Queue: Dominic Farolino <dom@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1175589}

--

wpt-commits: 9a325877b053ef636acb892df1e945eaeea5a212
wpt-pr: 41176
ErichDonGubler pushed a commit to erichdongubler-mozilla/firefox that referenced this pull request Aug 4, 2023
@domfarolino @moz-wptsync-bot
Bug 1845389 [wpt PR 41176] - Matches about:blank WPTs, a=testonly
aa4e46f 
Automatic update from web-platform-tests
Matches about:blank WPTs

This CL adds WPTs for whatwg/html#9558, which
uses the "matches about:blank" definition [1] in two places where
"about:blank" URL equivalence checks currently are.

[1]: https://html.spec.whatwg.org/#matches-about:blank

R=domenic@chromium.org

Bug: N/A
Change-Id: I840f445d3c7224f70a09e481f3e5727422ca2d83
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4718105
Reviewed-by: Domenic Denicola <domenic@chromium.org>
Commit-Queue: Dominic Farolino <dom@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1175589}

--

wpt-commits: 9a325877b053ef636acb892df1e945eaeea5a212
wpt-pr: 41176
Lightning00Blade pushed a commit to Lightning00Blade/wpt that referenced this pull request Dec 11, 2023
@domfarolino @Lightning00Blade
Matches about:blank WPTs
2a6a55c 
This CL adds WPTs for whatwg/html#9558, which
uses the "matches about:blank" definition [1] in two places where
"about:blank" URL equivalence checks currently are.

[1]: https://html.spec.whatwg.org/#matches-about:blank

R=domenic@chromium.org

Bug: N/A
Change-Id: I840f445d3c7224f70a09e481f3e5727422ca2d83
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4718105
Reviewed-by: Domenic Denicola <domenic@chromium.org>
Commit-Queue: Dominic Farolino <dom@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1175589}
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@domenic domenic domenic approved these changes

Assignees
No one assigned
Labels
topic: navigation
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@domfarolino @domenic