Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add popover=hint #9778

Open
wants to merge 41 commits into
base: main
Choose a base branch
from
Open

Add popover=hint #9778

wants to merge 41 commits into from

Conversation

josepharhar
Copy link
Contributor

@josepharhar josepharhar commented Sep 23, 2023

@mfreed7 mfreed7 mentioned this pull request Sep 29, 2023
3 tasks
@nt1m
Copy link
Member

nt1m commented Oct 8, 2023

I would probably want https://github.com/keithamus/invoker-buttons-proposal to be worked on first before addressing this, as I think it's a building block for this and other declarative attributes.

@mfreed7
Copy link
Contributor

mfreed7 commented Oct 30, 2023

I would probably want https://github.com/keithamus/invoker-buttons-proposal to be worked on first before addressing this, as I think it's a building block for this and other declarative attributes.

So I've significantly updated the popover=hint explainer, and there are a few sections detailing why I believe the functionality described in this PR is independent of the hover-triggering functionality described by the Invokers explainer (note that it was moved to the OpenUI repo). See this section:

Indeed both are important bits of functionality, but I'm hoping we can tackle them independently rather than needing to put up another huge spec PR. That didn't work very well for the original Popover spec PR, at least in my opinion.

@mfreed7 mfreed7 mentioned this pull request Oct 30, 2023
@josepharhar josepharhar added the topic: popover The popover attribute and friends label Dec 21, 2023
@josepharhar
Copy link
Contributor Author

Note to self: this will require additional changes in https://chromium-review.googlesource.com/c/chromium/src/+/5229300 if the corresponding PR to be opened gets merged

Copy link
Contributor

@mfreed7 mfreed7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, I reviewed mostly for the correctness of the algorithms, and things look pretty good. I made a few corrections, but other than those, LGTM.

source Outdated Show resolved Hide resolved
source Outdated Show resolved Hide resolved
source Outdated Show resolved Hide resolved
source Outdated Show resolved Hide resolved
source Outdated Show resolved Hide resolved
source Outdated Show resolved Hide resolved
source Outdated Show resolved Hide resolved
@mfreed7
Copy link
Contributor

mfreed7 commented Mar 7, 2024

Gentle ping - any chance we could get an initial review of this PR? @annevk @domenic

Copy link
Contributor

@emilio emilio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Conceptually looks good, though I think the current getStackPosition behavior is not correct / what we want? I might be wrong tho.

source Show resolved Hide resolved
@mfreed7
Copy link
Contributor

mfreed7 commented May 30, 2024

Conceptually looks good,

Cool, thanks for the review! Sounds like you're supportive of the PR in general? If so, mind marking that on mozilla/standards-positions#965?

though I think the current getStackPosition behavior is not correct / what we want? I might be wrong tho.

See my comment in the review - let's discuss there. I want to understand a bit better.

source Outdated Show resolved Hide resolved
source Show resolved Hide resolved
@mfreed7
Copy link
Contributor

mfreed7 commented Jul 25, 2024

This issue/PR was just discussed at the OpenUI/WHATWG/CSSWG form controls task force meeting, in the context of a more general discussion of the "tooltip" use case. The notes are located here:

https://logs.csswg.org/irc.w3.org/css/2024-07-25/#e1637392

@mfreed7
Copy link
Contributor

mfreed7 commented Aug 15, 2024

Conceptually looks good,

Cool, thanks for the review! Sounds like you're supportive of the PR in general? If so, mind marking that on mozilla/standards-positions#965?

@emilio any thoughts on this one? I.e. adding support (or not) from Mozilla's point of view, for popover=hint?

@josepharhar
Copy link
Contributor Author

I checked the implementer interest box now that mozilla is supportive: mozilla/standards-positions#965 (comment)

@zcorpan

@mfreed7
Copy link
Contributor

mfreed7 commented Oct 17, 2024

Cool, thanks all. I can file the MDN bug, which looks like the last checkbox to check. Anything else needed here in order to land this? @domenic

@domenic
Copy link
Member

domenic commented Oct 18, 2024

I'd like a chance to review the most recent changes, which will probably have to wait until Monday, but yeah, we should basically be good!

@mfreed7
Copy link
Contributor

mfreed7 commented Oct 18, 2024

I'd like a chance to review the most recent changes, which will probably have to wait until Monday, but yeah, we should basically be good!

Sounds great! Thanks.

Copy link
Member

@domenic domenic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Found a mismatched algorithm call, which I'm not sure how to fix, but otherwise looks good. (Be sure to pull in my nit fix commit as well.)

source Show resolved Hide resolved
source Show resolved Hide resolved
@mfreed7 mfreed7 mentioned this pull request Oct 21, 2024
1 task
@annevk
Copy link
Member

annevk commented Oct 21, 2024

WebKit is opposed to this. I don't think this should land.

@domenic
Copy link
Member

domenic commented Oct 22, 2024

Thanks for the comment @annevk. Am I to take it that WebKit is invoking the "strongly recommended" working mode criteria that "There should be no strong implementer objections to the new feature."?

@mfreed7
Copy link
Contributor

mfreed7 commented Oct 22, 2024

WebKit is opposed to this. I don't think this should land.

Thanks for the feedback, @annevk. With reference to the Standards of Behavior, I'd like to ask you to "Take actions that are constructive, and move towards consensus when possible". In this case, I think that'd include a lot more detail about the specifics of your objection, including what obstacles we'd have to overcome in order for you to be supportive of this proposal. I presume (but would love confirmation) that your objection here is related to your comment on the standards position request. If so, could you point out the person we should be talking to in order to co-design a tooltip/hovercard solution that works for Apple?

@mfreed7
Copy link
Contributor

mfreed7 commented Nov 7, 2024

We discussed, in two OpenUI meetings now, the utility of popover=hint in isolation. I.e. without an interesttarget feature. The developer feedback was solidly supportive, primarily because existing hovercards/tooltips today have to use popover=manual and then re-implement all of the light dismiss functionality via javascript. The popover=hint feature would remove the need to manually implement that logic.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
topic: popover The popover attribute and friends
Development

Successfully merging this pull request may close these issues.

popover=hint
8 participants