Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add commandfor & command attributes to HTMLButtonElement #9841

Open
wants to merge 21 commits into
base: main
Choose a base branch
from
Open

Add commandfor & command attributes to HTMLButtonElement #9841

Changes from all commits
Commits
Show all changes
21 commits
Select commit Hold shift + click to select a range
ece6a7a
Add commandfor & command attributes to HTMLButtonElement
keithamus Oct 5, 2023
449b84f
fix indentation
keithamus Nov 8, 2024
25cb9bb
s/and false otherwise/; otherwise false
keithamus Nov 8, 2024
8910fca
remove undeeded comma
keithamus Nov 8, 2024
4787019
move state outside span
keithamus Nov 8, 2024
6fa9256
fix casing in state names
keithamus Nov 8, 2024
1c64d6c
drop definitions for attributes mapping to idl definitions
keithamus Nov 8, 2024
d873b56
use correct terms for popover show/hide (not open/close)
keithamus Nov 8, 2024
c2c2355
more s/, then://
keithamus Nov 8, 2024
9392612
fix indentation
keithamus Nov 8, 2024
ccc2d54
reintroduce accidentally removed line break
keithamus Nov 8, 2024
0ba5dd6
fixup broken definition for popover visibility state
keithamus Nov 8, 2024
1d2ad94
make commandForElement properly reflect the commandfor attribute
keithamus Nov 8, 2024
2afda9a
reintroduce the command attribute definition
keithamus Nov 8, 2024
f734eb8
type and simplify the various invoker command steps
keithamus Nov 8, 2024
e3f9723
reintroduce the commandfor attribute definition
keithamus Nov 8, 2024
cdd0b4d
drop attribute reflection and use bespoke algorithms for command mapping
keithamus Nov 9, 2024
d897bd8
attempt to re-define submit button behavior with command/commandfor
keithamus Nov 9, 2024
37b8ed3
expand command getter steps into a list, always return string
keithamus Nov 10, 2024
87d9efb
expand type getter steps to ensure "submit" is only returned for vali…
keithamus Nov 10, 2024
88dd314
remove duplicate statement
keithamus Nov 10, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Loading