Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

we should namespace every mixin and function #9

Open
renatodeleao opened this issue Feb 21, 2019 · 5 comments
Open

we should namespace every mixin and function #9

renatodeleao opened this issue Feb 21, 2019 · 5 comments

Comments

@renatodeleao
Copy link
Collaborator

renatodeleao commented Feb 21, 2019

for consistency and usage with other tools, and to make clear from where's the source of that mixin.

Example

get-color() => qnorr-get-color()

Or

get-color() => qr-get-color()

clever naming is always welcomed..

@tomasmcm
Copy link
Member

how about qnorr:get-color() or qr:get-color()?

@renatodeleao
Copy link
Collaborator Author

I'm a fan of the : notation it's CCSy :) I've actually written some utilities in that format to group them, but i'm afraid that's not valid @mixin/@function naming. At least tested on sassmeister.

qnorr is short, so i'm keen to go with the verbose approach.

@renatodeleao
Copy link
Collaborator Author

accidentally find this: which means that namespacing issues with variables and mixins might be a thing of the past: https://css-tricks.com/introducing-sass-modules/

@tomasmcm
Copy link
Member

yeah... to use : we'd need to write qnorr\:clearfix().
The sass modules look great! We should test that and update documentation

@renatodeleao
Copy link
Collaborator Author

renatodeleao commented Nov 29, 2019

yeah... to use : we'd need to write qnorr\:clearfix().

🤦‍♂ Yes you're right! we already escaping special characters for breakpoints \@ so i don't think that would be a problem. Nice.

Yup wasn't that excited about sass in many years! Will definitely try this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants