Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update building.json #31

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions placetypes/building.json
Original file line number Diff line number Diff line change
@@ -1,9 +1,9 @@
{
"wof:id": 102312327,
"wof:id": 1260214523,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Aside from the fact that WOF ID are immutable once assigned this is a pre-existing WOF ID for a locality in Guinea - https://spelunker.whosonfirst.org/id/1260214523/

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok mais je vois que le nom est incorrecte ce tomba kanssa et non tomba dougoula pouvez vous coorige cela? @tomtaylor

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Author

@5212BABA 5212BABA May 21, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@thisisaaronland But what a genius thanks to you I manage to propose a modification on the file while waiting for the validation of my modification. Otherwise I have done everything for months to make changes to his files but I can't thanks to you today I manage to do it I thank you very sincerely for the link you send me and I am happy I will contact you if necessary thank you very much

"wof:name": "building",
"wof:role": "common_optional",
"wof:parent": [ "address", "intersection", "campus", "microhood", "neighbourhood" ],
"wof:concordances": {
"wd:id": "Q41176"
"wd:id": "Q116464161"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not the WikiData ID for the concept of a building but for a locality in Guinea – https://www.wikidata.org/wiki/Q116464161

}
}