Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(public account): add background for public account template #314

Merged
merged 2 commits into from
Dec 7, 2023

Conversation

VladislavSokov
Copy link
Contributor

@VladislavSokov VladislavSokov commented Dec 5, 2023

Screenshot from 2023-12-07 17-53-50

@ka8725
Copy link
Member

ka8725 commented Dec 5, 2023

@VladislavSokov we actually should configure a permanent redirect of "/" to "https://get.budgetingkid.com/".

Logged in users go to account but not logged in permanent redirect to the landing page.

@ka8725
Copy link
Member

ka8725 commented Dec 6, 2023

@VladislavSokov I've added the permanent redirect on AWS CF. So, we won't have "homepage" in this app. We should do this:

  • remove the "homepage"
  • improve the "choose role" to the production look & feel as we dicsussed
  • route "root" to the "choose role" page <-- this will be entry point of this app.

@VladislavSokov VladislavSokov changed the title fix(public account): add background for template fix(public account): add background for public account template Dec 7, 2023
@VladislavSokov
Copy link
Contributor Author

remove the "homepage"
improve the "choose role" to the production look & feel as we dicsussed
route "root" to the "choose role" page <-- this will be entry point of this app.

I will do this in a separate PR

This PR is fix the background of a public account page when the user is not logged in.

@ka8725 ka8725 merged commit ab5f003 into master Dec 7, 2023
2 checks passed
@ka8725 ka8725 deleted the bg-for-public-account branch December 7, 2023 16:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants