Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(cron): add check objectives task #342

Merged
merged 2 commits into from
Jan 6, 2024
Merged

fix(cron): add check objectives task #342

merged 2 commits into from
Jan 6, 2024

Conversation

VladislavSokov
Copy link
Contributor

No description provided.

app.json Outdated
},
{
"command": "rake check_objectives",
"schedule": "0 9-21/2 * * *"
Copy link
Member

@ka8725 ka8725 Jan 4, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why only 9-21? why around the clock? I think every hour is ok. or every 30 min.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We also could run it on demand in the points of the app that would affect it - on transaction added. And only for the affected account.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good idea, I'll think about it.

Copy link
Member

@ka8725 ka8725 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks awesome! Thanks!

@ka8725 ka8725 merged commit d0dd761 into master Jan 6, 2024
2 checks passed
@ka8725 ka8725 deleted the fix-check-objectives branch January 6, 2024 16:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants