Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Metadata resolution failure in one channel should not fail installation #221

Merged
merged 1 commit into from
Mar 22, 2024
Merged

Metadata resolution failure in one channel should not fail installation #221

merged 1 commit into from
Mar 22, 2024

Conversation

TomasHofman
Copy link
Contributor

Fixes #220

@TomasHofman
Copy link
Contributor Author

Can you review @jmesnil or @spyrkob ?

spyrkob
spyrkob approved these changes Mar 18, 2024
View reviewed changes
Copy link
Contributor

@spyrkob spyrkob left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Small nitpick - I'd add return Optional.empty() to the catch statements rather then relaying on default case, but that's just my preference.

@TomasHofman
Copy link
Contributor Author

Thanks @spyrkob , updated.

@jmesnil
Copy link
Member

jmesnil commented Mar 22, 2024

@TomasHofman could you please rebase and resolve the conflict?

@jmesnil jmesnil added this to the 1.1.0.Final milestone Mar 22, 2024
@TomasHofman
Copy link
Contributor Author

@jmesnil PR is rebased. Thanks!

@jmesnil jmesnil merged commit 2bb59b8 into wildfly-extras:main Mar 22, 2024
6 checks passed
@jmesnil
Copy link
Member

jmesnil commented Mar 22, 2024

@TomasHofman thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@spyrkob spyrkob spyrkob approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.1.0.Final
Development

Successfully merging this pull request may close these issues.

Combining multiple channels fails when resolve-if-no-stream: maven-release is used
3 participants
@TomasHofman @jmesnil @spyrkob